TinyXml 2.5.3

[killerbot]

yesterday TinyXml in CB has been updated from 2.5.2 to 2.5.3.

Today I discovered a bug in TinyXml, it happens with CDATA and escaping of all '<' and '>'

I think we should revert to 2.5.2 for now.

Other people any ideas/suggestions

[mandrav]

yesterday TinyXml in CB has been updated from 2.5.2 to 2.5.3.

Today I discovered a bug in TinyXml, it happens with CDATA and escaping of all '<' and '>'

I think we should revert to 2.5.2 for now.

Other people any ideas/suggestions

Revert it then.

[killerbot]

I have found the bug (well I think it is a bug) in TinyXml . I will keep the update but apply the fix :

Code

bool TiXmlPrinter::Visit( const TiXmlText& text )
{
	if ( text.CDATA() )
	{
		DoIndent();
		buffer += "<![CDATA[";
		buffer += text.Value();
		buffer += "]]>";
		DoLineBreak();
	}
	else if ( simpleTextPrint )
	{
		buffer += text.Value();
//		TIXML_STRING str;
//		TiXmlBase::EncodeString( text.ValueTStr(), &str );
//		buffer += str;
	}
	else
	{
		DoIndent();
		buffer += text.Value();
//		TIXML_STRING str;
//		TiXmlBase::EncodeString( text.ValueTStr(), &str );
//		buffer += str;
		DoLineBreak();
	}
	return true;
}

buffer += text.Value();    was replaced in the new version by the lines I have commented out now. I will investigate further.

[killerbot]

good news, it is probably a false alarm, and all is well.
Will do last test and adjust tomorrow   

[MortenMacFly]

good news, it is probably a false alarm, and all is well.
Will do last test and adjust tomorrow   

I would have wondered otherwise. Because I have carefully compared both revisions and truly there was not much difference except bug fixing. (You can checkout both versions yourself to see). That's why I've applied the update on SVN.
With regards, Morten.

[killerbot]

we (in our company) had some +- hack code, which got 'correctly' broken by the bugfix in TinyXml.
Short : TinyXml 2.5.3 is OK

[MortenMacFly]

Short : TinyXml 2.5.3 is OK

Phew! So I have only one thing broken in SVN - the compilation of envvars on linux. :roll: