Refixed wxWidget Patch: menu items with icon not correctly aligned (since wx263)

[stahta01]

The wxWidgets people have not done any thing yet, so I am starting work on the patch submission process.
I am looking at the wxWidgets sample going to try to compile and verify problem exists with ownerdrw sample. If anyone has a better sample to demo the bug please email me which one is better. Tim S

The menu sample in folder samples\menu shows the problem when I compile menu.cpp using Code::Blocks. Now I have to verify the problem exists using the makefile.gcc and that it is fixed with the patch applied.
Progress is being made on the patch submission. Note, I am using CVS Head for all of this testing.
Tim S

[stahta01]

Uploaded Patch to wxWidgets
  http://sourceforge.net/tracker/index.php?func=detail&aid=1626428&group_id=9863&atid=309863
Bug reported in:
  http://sourceforge.net/tracker/index.php?func=detail&aid=1626424&group_id=9863&atid=109863

Tim S

Edit: They rejected my patch, I think they rejected it too quick to have really looked at the issue.

[stahta01]

I found a flaw in my patch that I am working to fix.
Tim S

[killerbot]

great Tim 

[David Perfors]

It seems that you're patch is rejected....

[stahta01]

Someone applied it after they rejected it, by about a week.
Tim S

[David Perfors]

I see, probably rejected because it was incomplete (I think)

[stahta01]

I see, probably rejected because it was incomplete (I think)

Actually it was a valid reason to reject (They said to remove the fix, by applying my patch, for something else would result in some bug returning) but I asked it to be applied to CVS head so someone would find out what it breaks, I just assumed it would be someone other than me that would get bitten by the breakage.

Tim S 

[stahta01]

I am testing my back port of the wxWidgets 2.8.1+ code to fix the issue on the 2.6 branch.
Tim S

[stahta01]

I have uploaded my back port of how this problem was fixed in CVS head. The fix is patch 1637808 which updates the file menu.cpp. I would apply the patch 1637804  before doing this patch because menu uses code in the file ownerdrw.cpp.

Tim S

[ 1637808 ] MSW: menu.cpp backport to 2.6_BRANCH from cvs head
http://sourceforge.net/tracker/index.php?func=detail&aid=1637808&group_id=9863&atid=309863

[ 1637804 ] MSW: ownerdrw.cpp backport to 2.6_BRANCH from cvs head
http://sourceforge.net/tracker/index.php?func=detail&aid=1637804&group_id=9863&atid=309863

[killerbot]

these are based on the wx guys solution to the problem. Since I once tried an earlier attempt of you (graying out of icons), but then th first letter could duplicated. Is this now a new way. Just to be sure, I don't try out twice the same ;-)

[stahta01]

Yes, this one does not double the first letters.

All my testing was with both of these patches applied.

Tim S

Edit: Before i was testing each patch by itself and discovered an problem of double the first letters happened when both patches where applied. This was because the alignment patch had code issues.

[killerbot]

I have build  new wx dll by applying these 2 patches on the wx263p2 code and have tested with revision 3295 (rather old !!!). these are the results :
 - menus (with or without) icons alligned correctly
 - icons grayed out  in the menu as they should be
 - 90% of the icons are gone (due to keybinder)

updating my CB now to the latest revision, will adjust this post with the new results.
[EDIT : test finished]
with the latest svn revision 3516 : all is OK (all icons present) !!   

[Pecan]

I have build  new wx dll by applying these 2 patches on the wx263p2 code and have tested with revision 3295 (rather old !!!). these are the results :
 - menus (with or without) icons alligned correctly
 - icons grayed out  in the menu as they should be
 - 90% of the icons are gone (due to keybinder)

updating my CB now to the latest revision, will adjust this post with the new results.

I think you'll find that TimS's fix to keybinder to match his wxWidgets fixes occured in SVN 3443.

[killerbot]

@Tim : did the wx guys already fix the issue that relates to our problem where the replace button on the toolbar in windows being incorrect and showing the find button ??