Patches to compile and link C::B against wxWidgets 2.8.0

[killerbot]

I even was able to run it, and at first glance very disappointed !!
In wx263 they introduced (apparently only on windows, since on linux it looks ok) the 'misalignment' of menus  [entries with and without icons], were that was ok in wx 262. But breaking interfaces in wx 2.8 and deprecating stuff, plenty, but fixing the bugs they have introduced, hell no :-( :-( :-(

[stahta01]

I applied most of the patches in svn, some I did local on my machine [the scripting one and the cbp's and for selecttarget I have disabled the event handler mapping to the old OnOK for the moment ] => I can build except wxSmith. Any news on that one ?

I have a patch for the new wxSmith, I have decided the old one is not worth the effort to fix. Also, I spent several hours and failed to find a fix for it. EDIT: An experienced wxWidgets and C++ person could maybe see a solution for it quickly, but it stumped me.
The patch for the new wxSmith is here.
[ Patch #1702 ] patch to the (correction in title) [NEW] wxSmith to use wxPropertyGrid version 1.2.x
https://developer.berlios.de/patch/?func=detailpatch&patch_id=1702&group_id=5358

Note: the above patch patches for wxWidgets 2.8.0 and for use with wxPropertyGrid version 1.2.x; it still works with the old wxPropertyGrid 1.0.6 that C::B is currently using.

EDIT: I just reviewed my solution for the new wxSmith and it gave me idea on fixing the old wxSmith, so I am going to try again.

EDIT: created new patch for new wxSmith for wxWidgets 2.8 issues.
 [ Patch #1766 ] NEW (experimental) wxSmith patch for wxWidgets 2.8 Submitted By: stahta01
  https://developer.berlios.de/patch/?func=detailpatch&patch_id=1766&group_id=5358

Tim S

[SharkCZ]

Are the sources for the new wxSmith available somewhere? I cannot find them :-)

[stahta01]

Are the sources for the new wxSmith available somewhere? I cannot find them :-)

How to get the new wxSmith is here
http://forums.codeblocks.org/index.php?topic=3765.msg33855#msg33855

Here's the last window checkout command I used.

SET PATH=C:\Program Files\Subversion\bin
CD codeblocks\src\plugins\contrib
svn checkout svn://svn.berlios.de/codeblocks/branches/New_wxSmith New_wxSmith

Tim S

[stahta01]

I applied most of the patches in svn, some I did local on my machine [the scripting one and the cbp's and for selecttarget I have disabled the event handler mapping to the old OnOK for the moment ] => I can build except wxSmith. Any news on that one ?

The patch for the OLD wxSmith, note I don't use wxSmith so needs testing.
 [ Patch #1767 ] Old wxSmith patch for wxWidgets 2.8
   https://developer.berlios.de/patch/index.php?func=detailpatch&patch_id=1767&group_id=5358

Tim S

[David Perfors]

I am using the latest svn version now, but I still can't compile against 2.8. There seems to be a problem with the wxStartTime() and wxGetElapsedTime() (or something like that) in wxScintella. Those functions are deprecated (according to the documentation) but do not exist in the header files of wx.

[stahta01]

I am using the latest svn version now, but I still can't compile against 2.8. There seems to be a problem with the wxStartTime() and wxGetElapsedTime() (or something like that) in wxScintella. Those functions are deprecated (according to the documentation) but do not exist in the header files of wx.

Have you applied the patches in the first message in this thread?
http://forums.codeblocks.org/index.php?topic=4495.msg35563#msg35563

Added patches needed below.

Patches to Code::Blocks projects files (Needed by windows Users ONLY):
 [ Patch #1733 ] wxmsw28 patch for wxWidgets 2.8
   https://developer.berlios.de/patch/?func=detailpatch&patch_id=1733&group_id=5358
 
Patches to core Code::Blocks project:
 [ Patch #1737 ] selecttargetdlg patch for wxWidgets 2.8 Submitted By: stahta01
   https://developer.berlios.de/patch/index.php?func=detailpatch&patch_id=1737&group_id=5358
 [ Patch #1731 ] scripting patch for wxWidgets 2.8
   https://developer.berlios.de/patch/index.php?func=detailpatch&patch_id=1731&group_id=5358

Patches to contrib Code::Blocks projects:
[ Patch #1732 ] keybinder plugin patches for wxWidgets 2.8 Submitted By: stahta01 based on afb work.
   https://developer.berlios.de/patch/index.php?func=detailpatch&patch_id=1732&group_id=5358

I am assuming Win XP and unicode is this correct?

How did you get wxWidgets 2.8.0? They had some issues packaging it, I downloaded the file wxMSW-2.8.0.tar.bz2.

Tim S

[stahta01]

I am using the latest svn version now, but I still can't compile against 2.8. There seems to be a problem with the wxStartTime() and wxGetElapsedTime() (or something like that) in wxScintella. Those functions are deprecated (according to the documentation) but do not exist in the header files of wx.

Please verify the following is set to 1 in lib\gcc_dll\mswu\wx\setup.h

wxUSE_LONGLONG
WXWIN_COMPATIBILITY_2_6

They guard the code in wx/stopwatch.h

Tim S

[David Perfors]

I didn't apply those patches, the first one, I didn't see so I did it by hand
The other two are not relevant to the problem (I think)

I use XP and wx unicode build. I got the wxALL-2.8.0.something (don't know exactly).

I will look to the WXWIN_COMPATIBILITY_2_6. Most likely that is the problem

*Edit* That was the problem. I had compiled it without 2.6 compatibility...

[stahta01]

The patch for the OLD wxSmith for wxWidgets 2.8.0 bug
 [ Patch #1771 ] Old wxSmith patch for wxListbook::HitTest protected wxW2.8
  https://developer.berlios.de/patch/index.php?func=detailpatch&patch_id=1771&group_id=5358

I just found out today that I was NOT testing with the final release of wxWidgets 2.8.0; when I changed I got an new error in the old wxSmith fix above.

Tim S

[Pecan]

RE: patch1732 to keybinder.

Looking at defs.h for 2.8.0,

Code

    WXK_PAGEUP,
    WXK_PAGEDOWN,
#if WXWIN_COMPATIBILITY_2_6
    WXK_PRIOR = WXK_PAGEUP,
    WXK_NEXT  = WXK_PAGEDOWN,
#endif

I don't get the purpose of the patch unless the intent is to run without 2.6 compatibilty.

Even if that were true, the patch hacks the problem and causes others (since new code will have to be written to avoid current dependency on wxk_prior/next).

Any explanation?

[stahta01]

RE: patch1732 to keybinder.

Looking at defs.h for 2.8.0,

Code

    WXK_PAGEUP,
    WXK_PAGEDOWN,
#if WXWIN_COMPATIBILITY_2_6
    WXK_PRIOR = WXK_PAGEUP,
    WXK_NEXT  = WXK_PAGEDOWN,
#endif

I don't get the purpose of the patch unless the intent is to run without 2.6 compatibilty.

Even if that were true, the patch hacks the problem and causes others (since new code will have to be written to avoid current dependency on wxk_prior/next).

Any explanation?

The values need to be gated by WXWIN_COMPATIBILITY_2_6 because they are being used in a switch statement, if NOT done you get a compile error on duplicate CASE values.

Tim S

[Pecan]

The values need to be gated by WXWIN_COMPATIBILITY_2_6 because they are being used in a switch statement, if NOT done you get a compile error on duplicate CASE values.

Tim S

Yes, I finally get it. Commit 3440.
This does not mean that keyBinder will work properly with 2.8.
It just means no compiler errs.
 

[David Perfors]

We know, the most of the patches are to avoid compiler errors.

In fact, is it true that icons on the toolbar that should be grey, are invisible (well they are grey, but most of the time the whole area of the icon is dark grey)

[stahta01]

Number of Warnings is from Windows XP Unicode wxW2.8 CVS Label WX_2_8_MICROFIX_BRANCH;
  compiled with minGW GCC 3.4.2 API 3.8

Terms:
  Main: the code compiled by project file CodeBlocks.cbp
  Contrib: the code compiled by workspace file ContribPlugins.workspace
  SDK: the code under folder src/sdk
  Main Plugins:the code under src/plugins, but NOT under src/plugins/contrib
  Contrib Plugins:the code under src/plugins/contrib
  Core: the code under src/src

Code

Number      Area       
 87         Main
 22         Contrib
109         Total

Code

Number      Section
  7         SDK/wxscintilla
 13         SDK/wxPropertyGrid
  6         SDK/wxFlatNotebook
 24         SDK other
  8         Core
 14         MainPlugins/Compiler
  4         MainPlugins/Debugger
  3         MainPlugins/Code-completion
  2         MainPlugins/Class wizard
  4         MainPlugins/Scripted wizard
  2         MainPlugins/To-do
  3         ContribPlugins/EnvVars Plug-In
  5         ContribPlugins/C::B KeyBinder
  8         ContribPlugins/Exporter/wxPdfDocument
  6         ContribPlugins/wxSmith

Sections NOT worth patching because section is maintained by external group
    SDK/wxscintilla
    SDK/wxPropertyGrid
    SDK/wxFlatNotebook
    ContribPlugins/Exporter/wxPdfDocument

 Note: I am working on a patch to upgrade wxPropertyGrid to a newer version 1.2.x

Deprecated methods NOT worth patching as long as C::B uses wxWidgets 2.6.x
  wxWindow::SetBestFittingSize
  wxWindow::GetBestFittingSize
  wxPathList::Member
  wxRect::Inside
  ::wxGetAccelFromString

Note: I plan to patch the MainPlugin/Compiler use of deprecated methods wxStartTimer & wxGetElapsedTime in a separate patch.

Totals after warning reduction patches and module upgrade patches applied
[Totals being ran at current time, will update totals after run is done.]

Code

Number      Area       
 29         Main
 22         Contrib
 51         Total

Code

Number      Section
  7         SDK/wxscintilla
  0         SDK/wxPropertyGrid
  6         SDK/wxFlatNotebook
  1         SDK other
  4         Core
  7         MainPlugins/Compiler
  3         MainPlugins/Debugger
  1         MainPlugins/Code-completion
  0         MainPlugins/Class wizard
  0         MainPlugins/Scripted wizard
  0         MainPlugins/To-do
  3         ContribPlugins/EnvVars Plug-In
  5         ContribPlugins/C::B KeyBinder
  8         ContribPlugins/Exporter/wxPdfDocument
  6         ContribPlugins/wxSmith

Tim S