The 12 october 2006 build is out.

[Belgabor]

Project | Remove Files...

It does absolutely nothing. It doesn't crash. It doesn't bring up a dialog. Now I just edit the .CBP file to remove files from my projects.

You can also remove files via right-click on the list tree.

[tiwag]

Project | Remove Files...

It does absolutely nothing. It doesn't crash. It doesn't bring up a dialog. Now I just edit the .CBP file to remove files from my projects.

it does nothing until you select any project in the project manager pane.

[killerbot]

Hi All,
A quick update:

wxFlatNotebook V2.1 is released and can be downloaded from SF.

here is summary:
Accepted changes:
- Added style wxFNB_ALLOW_FOREIGN_DND
- DeletePage, RemovePage now accepts second argument 'notify' to allows user to enable/disable
  firing of the PAGE_CLOSE/CLOSING events
- All XPM files are now located under fnb_reousrces.cpp, include fnb_resources.h
  if you need them
- OnRightDown - the if( m_pRightClickMenu ) was removed, when looking at the code
  I did support for custom user menus, but forgot to remove this 'if' ...
- SetSelection now fires the events: wxEVT_COMMAND_FLATNOTEBOOK_PAGE_CHANGED/ ING instead of OnLeftDown
- OnDropTarget - changed to fit the new style wxFNB_ALLOW_FOREIGN_DND
- Fixed drawing issues with VC7.1 & Fancy style AND bottoms tabs
- Added the missing 'x' button on active tab for VS8 style

Not accepted:
- Changes to the header include (1, 2, 3)
- AddPage, InsertPage - Not accepted, I am not sure if it is needed anymore. However, I DO know
  that a invisible tab must have -1, -1 position set. So far I did not get any drawing
  artifacts, can you guys check and tell me if it still exists?
- OnMiddleDown - like you mentioned, this patch can safely be ignored

Hope now it will be easier for you to handle new versions of wxFlatNotebook

Eran

CB sources updated :
 - did not re-apply the OnMiddleDown (for above reasons)
 - headers remain unchanged -> restructured our source tree
 -AddPage/InsertPage not re-applied, let's see what gives ...

1 *important* change in wxFlatNotebook.cpp : the comment where the boss's name is mentioned "Yiannis".
In your sources it's misspelled ... we don't want to get the Don angry ;-)

[eranif]

1 *important* change in wxFlatNotebook.cpp : the comment where the boss's name is mentioned "Yiannis".
In your sources it's misspelled ... we don't want to get the Don angry Wink

I could not find it in my sources ... maybe I deleted it by accident?  :oops:

just give me the line number and source (and the comment) and I will add it again ...

Eran

[severach]

it does nothing until you select any project in the project manager pane.

"Add Files.." works anytime and "Remove Files..." only works when a project is selected. That discontinuity is why I didn't look any further. Add, Add Recursively, and Remove must behave exactly the same. You have some options:

1 All grayed out when a project is not selected
2 All available when a workspace contains exactly one project even if it isn't selected
3 An irritating dialog is displayed telling me to click on something or other before trying again.
4 Both always apply to the project that is currently active. There is no need to select it. The options were never greyed out or non working before because there must always be an active project and what does active mean anyways if not that?

I prefer #4 because that's the way Add already works. If I want to add to a project other than the active one I can right click.

[killerbot]

1 *important* change in wxFlatNotebook.cpp : the comment where the boss's name is mentioned "Yiannis".
In your sources it's misspelled ... we don't want to get the Don angry Wink

I could not find it in my sources ... maybe I deleted it by accident?  :oops:

just give me the line number and source (and the comment) and I will add it again ...

Eran

line 1189 :

Code

	// Thanks to Yiannis AKA Mandrav

[tiwag]

it does nothing until you select any project in the project manager pane.

"Add Files.." works anytime and "Remove Files..." only works when a project is selected. That discontinuity is why I didn't look any further. Add, Add Recursively, and Remove must behave exactly the same. You have some options:

1 All grayed out when a project is not selected
2 All available when a workspace contains exactly one project even if it isn't selected
3 An irritating dialog is displayed telling me to click on something or other before trying again.
4 Both always apply to the project that is currently active. There is no need to select it. The options were never greyed out or non working before because there must always be an active project and what does active mean anyways if not that?

I prefer #4 because that's the way Add already works. If I want to add to a project other than the active one I can right click.

write a bugreport to berlios if you can't live with that behaviour ...

[mandrav]

wxFlatNotebook V2.1 is released and can be downloaded from SF.

<snip>

Not accepted:
- AddPage, InsertPage - Not accepted, I am not sure if it is needed anymore. However, I DO know
  that a invisible tab must have -1, -1 position set. So far I did not get any drawing
  artifacts, can you guys check and tell me if it still exists?

Now that killerbot has updated our copy of wxFNB to v2.1, I saw (and remembered) what this SetPosition() was supposed to fix.
You can look yourself in C::B messages wxFNB. Suppose that when you close C::B, the "Build log" is the active page. When C::B starts up again, it tries to re-activate the last-active page (the "Build log" in this case). It succeeds doing that but notice what happens without the SetPosition(): The "Build log" is activated but it is set as the first visible tab. One needs to scroll back to see the other tabs.
With the SetPosition() patch, the active tab does not become the first visible too.

At least that's what I remember .

[eranif]

I agree with this behavior, and I can confirm it.

BUT, using your solution causes another problem:

When I open the demo, and typing Ctrl+N a new page is added
and set as selected.

Now, when the room for drawing tabs is full, and scrolling is needed, the active tab is not visible until the next Ctrl+N !

in other words, your solution affects the visibility of the selected tab in other cases.

I still think that the behavior you descrivbed is a bug, and I will find another way to solve it.

With regards,
Eran

[eranif]

Ok, I compared the behavior you described with other application I wrote, and the desired solution is to place the selected tab as last (incase it cant fit into the screen)

I will let you guys know when a fix is ready,

Eran

[mandrav]

I agree with this behavior, and I can confirm it.

BUT, using your solution causes another problem:

When I open the demo, and typing Ctrl+N a new page is added
and set as selected.

Now, when the room for drawing tabs is full, and scrolling is needed, the active tab is not visible until the next Ctrl+N !

in other words, your solution affects the visibility of the selected tab in other cases.

I still think that the behavior you descrivbed is a bug, and I will find another way to solve it.

With regards,
Eran

Thanks Eran.
My point was not to "force" you use that particular patch, I just remembered what this was supposed to fix (as a quick hack).
I 'm glad you saw the problem and we 're now eagerly awaiting for the fix .

[severach]

I'm sure this applies to any version but I'm running Oct 12 so I should post it here.

Add Files Recursively will occasionally add a file already in the project again. I suspect this is because of the Win32 case preserving case insensitive file system. For Win32 a case insensitive compare needs to be inserted somewhere in the dup detection.

[severach]

MinGW lib generation has a bug. Each time I load the Interactive Data Objects project, "lib" gets added to the beginning of the lib name. This results in a succession of library names.

IDO.a
libIDO.a  :shock:
liblibIDO.a
libliblibIDO.a

It's pretty cute but darned annoying to keep going back and removing lib.

[mandrav]

MinGW lib generation has a bug. Each time I load the Interactive Data Objects project, "lib" gets added to the beginning of the lib name. This results in a succession of library names.

IDO.a
libIDO.a  :shock:
liblibIDO.a
libliblibIDO.a

It's pretty cute but darned annoying to keep going back and removing lib.

And the reason why you have not updated to a more recent nightly where this has been fixed?

[severach]

Because I didn't believe that it would have been fixed within the last 8 days.