The fact we put the include sdk.h there, is to support precompiled headers.
You could also directly use the wx precompiled header for this. Note that the sdk.h has a bigger list then the native wx one. :evil:
As it is again now, sureley the including of wx/string.h is missing !!
It might come in through the including of wx/wxprec.h in the kodersdialog.h
As for as I have been told, you should NOT include thoe precomiled driven headers in a header file
So
1) the including of wx/wxprec.h needs to be removed from the header
I don't know it that was generated by wxSmith or not, if it is we should talk to byo. He's already aware of the not needed header includings generated in the dialog header, and told m that would be fixed in the new wxSmith. Therefor I would suggest @Morton, you put back back the forward declarations and the includes in the cpp file (see point 3), so that when the switch no new wxSmith will be made, that the code is already ok, and we just need to move the wxSmith block (from .h to .cpp)
2) wx/string.h include should be added (I will do that again)
3) Choose if you want to work with precompiled headers or not :
if not then it should be like this :
#include <wx/button.h>
#include <wx/choice.h>
#include <wx/intl.h>
#include <wx/settings.h>
#include <wx/sizer.h>
#include <wx/stattext.h>
#include <wx/string.h>
#include <wx/textctrl.h>
#include "kodersdialog.h"
if yes, then it should be like this :
#include "sdk.h"
#ifndef CB_PRECOMP
#include <wx/button.h>
#include <wx/choice.h>
#include <wx/intl.h>
#include <wx/settings.h>
#include <wx/sizer.h>
#include <wx/stattext.h>
#include <wx/string.h>
#include <wx/textctrl.h>
#endif
#include "kodersdialog.h"
Note that the result of including a precompiled header in the case when no precompiled directive is given to the project(compiler) is(should be) a no-op. So you include just nothing. So in this case, who will bring in wx/string.h. We might be lucky someone else included it, but that's no guarantee.
@Morton,
I will add the include wx/string.h . I leave the rest up to you, it's your call to either support or not support precompiled headers.
PS : will finish up my header including topic this weekend ;-)
