Toggle comment

[lfm]

There are some unicode string in my test application. I have  commented all code in main.cpp, then selected all code, when i  "Edit->Toggle comment", a error occured, look follows pictures:


[attachment deleted by admin]

[lfm]

I was disappointed , why nobody interested?

[sethjackson]

I was disappointed , why nobody interested?

Well I for one am interested (and I'm pretty sure others are too).

Could you submit this bug to BerliOS?

[lfm]

Well I for one am interested (and I'm pretty sure others are too).
Could you submit this bug to BerliOS?

Thank you! But my bad English... :oops:

[killerbot]

a few questions :

1) when you report the bug : please add your little test project, containing the main.cpp we see in the screenshot
2) when that little unicode string is removed, does the bug still happen

[lfm]

a few questions :
1) when you report the bug : please add your little test project, containing the main.cpp we see in the screenshot
2) when that little unicode string is removed, does the bug still happen

1. The project file had be added.
2. when that little unicode string is removed, the bug does not happen.

[attachment deleted by admin]

[lfm]

Now ,i use rev 2516, but that problem still happen. My steps:
1. open the file that include unicode strings, There isn't comment in the file this time;
2. click "Edit->Select all", then click "Edit->Toggle comment", comment all in file ;
3. click "Edit->Select all", still click "Edit->Toggle comment", problem happen.

[killerbot]

Now ,i use rev 2516, but that problem still happen. My steps:
1. open the file that include unicode strings, There isn't comment in the file this time;
2. click "Edit->Select all", then click "Edit->Toggle comment", comment all in file ;
3. click "Edit->Select all", still click "Edit->Toggle comment", problem happen.

we are looking into it, we already narrowed the spot where it goes wrong, a little bit more investigation and hopefuly a solution ...

[lfm]

rev 2544, this problem still happen.

[lfm]

Please attend to this problem.

[sethjackson]

Umm killerbot why doesn't this work (Yeah I know it has to do with Unicode)? The watches dialog shows square boxes for the Unicode characters. I think this problem happens in main.cpp around line 2205.......

[killerbot]

I have done some debugging once, and I felt like it was going wrong at :
               stc->ReplaceTarget( strLine );
(during uncomment).
Should check my notes again. I kind of had the impression it could be a wxScintilla problem...

[sethjackson]

I have done some debugging once, and I felt like it was going wrong at :
               stc->ReplaceTarget( strLine );
(during uncomment).
Should check my notes again. I kind of had the impression it could be a wxScintilla problem...

Hmm maybe wxScintilla has a problem with Unicode.......

[killerbot]

for those interested, attached zip file contains a simple main.cpp.
Put your cursor at the start of the (first) line and select the uncomment command --> you can see the problem ;-)

Here's a little modified part of the codfe from (the CB source that is) main.cpp::MainFrame::OnEditUncommentSelected()
In comments I have put the values from the debugger in the above example :

Code

int commentPos = strLine.Strip( wxString::leading ).Find( Comment );
if( commentPos ==0 )
{
	// Uncomment
	strLine.Replace( Comment, _T( "" ), false );

	// Update
	int start = stc->PositionFromLine( startLine );       // 0
	stc->SetTargetStart( start );
	// adjust for the '//' we erased
	int x = strLine.Length();                                    // 18
	int y = Comment.Length();                                // 2
	stc->SetTargetEnd( start + strLine.Length() + Comment.Length() );  // 20
	stc->ReplaceTarget( strLine );
}

These values seems correct, but after the stc->ReplaceTarget the damage is done.

I'll try to test if it works with the new wxScintilla, but I have already a workaround in mind which I am gonna try out first.

Note that "commenting" the line works, for that purpose stc->InsertText was used, and that seems to work well.

[attachment deleted by admin]

[killerbot]

allright my workaround works this is the same part of code, but with the fix : I will commit later this evening.
If you see troubles in the solution, feel free to post.

Code

int commentPos = strLine.Strip( wxString::leading ).Find( Comment );
if( commentPos ==0 )
{      // we know the comment is there (maybe preceded by white space)
	int Pos = strLine.Find(Comment);
	int start = stc->PositionFromLine( startLine ) + Pos;
	int end = start + Comment.Length();
	stc->SetTargetStart( start );
	stc->SetTargetEnd( end );
	stc->ReplaceTarget( wxEmptyString );
}

 


[EDIT] : And I will do the same thing in OnEditToggleCommentSelected ;-)