Batchbuilds broken ?

[tiwag]

since a few revisions, i can't use batchbuild anymore,
it errors out with access to 0x00000000

CB svn rev 2272 ... 2275, unicode, wx262, OS: WinXP SP2

has anyone noticed this too ?

[edit]
further info: it crashes at this line :

    m_BuildingProjectIdx = m_BuildDeps[m_BuildDepsIndex];

[thomas]

Works fine in 2266, crashes in 2269.

EDIT: Can only speculate it is due to the changes to app.cpp in 2267 (delay opening of DDE files to work around "cannot find..." bug). Don't know the reason though.
None of the other revisions in question changed anything even remotely related to building, projects, or files, however.

Once again, I think we should abandon DDE entirely and create a solution that works without hacks.

[sethjackson]

Once again, I think we should abandon DDE entirely and create a solution that works without hacks.

Second that. 

[mandrav]

Fixed, thanks.
Btw, it had nothing to do with DDE...

[thomas]

Not that it matters, but I wonder what makes you say so...

Maybe my interpretation is inaccurate, but
- the problem appeared right after a workaround to make DDE work was introduced
- the bugfix cosists of setting s_Loading and calling DelayLoadDdeFiles()
- both s_Loading and DelayLoadDdeFiles() have to do with a DDE workaround

To me, it seems justified to say that DDE is the root of evil for many of your problems. Maybe not directly, but indirectly, caused by the workarounds which are necessary to make DDE behave.

Anyway, as said in my other post, I don't have the time to properly implement an alternate IPC, even though I believe it would be a good idea
Still waiting for those 35 volunteers from the community to step forward...

[mandrav]

Not that it matters, but I wonder what makes you say so...

Actually the function DelayLoadDdeFiles is mis-named. It should be DelayLoadFiles, so no connection with DDE
And the bug in question was that I had moved the files loading to the end of the app creation, but the batch was trying to run before loading the files.

[tiwag]

Fixed, thanks.
Btw, it had nothing to do with DDE...

thanks too

[TheNullinator]

Actually the function DelayLoadDdeFiles is mis-named. It should be DelayLoadFiles, so no connection with DDE

Yeah, I noticed that when looking through the code earlier.  It doesn't make much sense to have a Windows specific name when it's not inside a __WXMSW__ conditional block.