Multiple declarations/definitions of wxSwitcherDialog

[christo]

wxSwitcherDialog is declared/defined  in  src/src/switcherdlg.h / switcherdlg.cpp and
src/plugins/contrib/BrowseTracker/btswitcherdlg.h   /  btswitcherdlg.cpp

The two implementations are different.

@Developers, Shall I rename that in BrowseTracker to use a different class name?

I'm trying to do more static linking in autotools to create a more portable linux appImage eventually and the above problem causes crashes.

Code

(gdb) bt
#0  0x00000000007fb392 in wxEventTableEntryBase::~wxEventTableEntryBase (this=0x144fb80 <wxSwitcherDialog::sm_eventTableEntries+96>)
    at /usr/include/wx-3.2/wx/event.h:3501
#1  0x00000000007fe998 in wxEventTableEntry::~wxEventTableEntry (this=0x144fb80 <wxSwitcherDialog::sm_eventTableEntries+96>)
    at /usr/include/wx-3.2/wx/event.h:3520
#2  0x0000000000921603 in __tcf_ZN16wxSwitcherDialog20sm_eventTableEntriesE () at switcherdlg.cpp:848
#3  0x00007ffff5a47a76 in __run_exit_handlers
    (status=0, listp=<optimized out>, run_list_atexit=run_list_atexit@entry=true, run_dtors=run_dtors@entry=true) at ./stdlib/exit.c:108
#4  0x00007ffff5a47bbe in __GI_exit (status=<optimized out>) at ./stdlib/exit.c:138

[Miguel Gimenez]

I would rename the former as cbSwitcherDialog (or just SwitcherDialog) and the latter as btSwitcherDialog.

There are some classes in C::B named wxSomething, this creates confussion with wxWidgets' own classes.

[christo]

Thanks Miguel Gimenez, I'll do that

Renamed in svn revision 13859