« previous next »
Pages: [1]   Go Down

Author Topic: svn rev 13798 issue?  (Read 257 times)

Offline ollydbg

  • Developer
  • Lives here!
  • *****
  • Posts: 6169
  • OpenCV and Robotics
    • Chinese OpenCV forum moderator
svn rev 13798 issue?
« on: Yesterday at 02:39:15 am »
Hi, Pecan, I see this commit:

https://sourceforge.net/p/codeblocks/code/13798/

Some of changes in the cbp files are not expected? I think the macro variable "CODEBLOCKS" is not needed here.
Logged
If some piece of memory should be reused, turn them to variables (or const variables).
If some piece of operations should be reused, turn them to functions.
If they happened together, then turn them to classes.

Offline Pecan

  • Plugin developer
  • Lives here!
  • ****
  • Posts: 2914
Re: svn rev 13798 issue?
« Reply #1 on: Yesterday at 05:01:35 pm »
Do you mean that it's causing an error. Where do you get the error?

What OS? What compiler? Which wxWidgets?

I can't reproduce an error. Can you give me some steps to cause the error?
Thanks
« Last Edit: Yesterday at 05:57:27 pm by Pecan »
Logged

Offline ollydbg

  • Developer
  • Lives here!
  • *****
  • Posts: 6169
  • OpenCV and Robotics
    • Chinese OpenCV forum moderator
Re: svn rev 13798 issue?
« Reply #2 on: Today at 01:46:50 am »
You must have the compiler global variable CODEBLOCKS defined.

But that was not necessary.  For example, if you look at this cbp file and other cbp files.

https://github.com/arnholm/codeblocks_sfmirror/blob/master/src/plugins/contrib/SmartIndent/SmartIndent_wx32_64.cbp

You don't see any CODEBLOCKS variable needed.

I'm not sure you can understand my explanations.  But this compiler macro is not needed in cbp file and the update file.
Logged
If some piece of memory should be reused, turn them to variables (or const variables).
If some piece of operations should be reused, turn them to functions.
If they happened together, then turn them to classes.
Pages: [1]   Go Up
« previous next »