« previous next »
Pages: [1]   Go Down

Author Topic: sdk\editormanager.cpp  (Read 4917 times)

sethjackson

  • Guest
sdk\editormanager.cpp
« on: March 05, 2006, 10:30:58 pm »
Why does there need to be a wxNotebookSizer? The wx manual says it is depreciated. Besides we use wxFNB not wxNotebook.  :? Patch below gets rid of it....

Code: diff
Index: src/sdk/editormanager.cpp
===================================================================
--- src/sdk/editormanager.cpp	(revision 2141)
+++ src/sdk/editormanager.cpp	(working copy)
@@ -208,11 +208,6 @@
 
     CreateSearchLog();
     LoadAutoComplete();
-
-#if !wxCHECK_VERSION(2, 5, 0)
-    /*wxNotebookSizer* nbs =*/
-    new wxNotebookSizer(m_pNotebook);
-#endif
 }
 
 // class destructor


EDIT:

BTW I posted it to the tracker here.

https://developer.berlios.de/patch/index.php?func=detailpatch&patch_id=897&group_id=5358

« Last Edit: March 05, 2006, 10:42:54 pm by sethjackson »
Logged

Offline thomas

  • Administrator
  • Lives here!
  • *****
  • Posts: 3979
Re: sdk\editormanager.cpp
« Reply #1 on: March 05, 2006, 10:52:02 pm »
wxWidgets 2.4.2
Logged
"We should forget about small efficiencies, say about 97% of the time: Premature quotation is the root of public humiliation."

sethjackson

  • Guest
Re: sdk\editormanager.cpp
« Reply #2 on: March 05, 2006, 11:58:01 pm »
Quote from: thomas on March 05, 2006, 10:52:02 pm
wxWidgets 2.4.2

And who uses that? You cant compile startherepage.cpp with 2.4.2 because of wxLaunchDefaultBrowser() so...... Do we really need to be backwards compatible with 2.4.2?
Logged
Pages: [1]   Go Up
« previous next »