Developer forums (C::B DEVELOPMENT STRICTLY!) > Development
Problem with icons on HiDPI displays
oBFusCATed:
The changes are in trunk/master. If you have problems don't hesitate to report them. Sometime next week I'll probably add the other sizes.
Also I plan to remove the 22x22 size, because it seems redundant.
BlueHazzard:
Looks fine for me windows 7 and windows 10
wx30 (for the moment)
beside this:
--- Quote ---One thing that bothers me is that there is no message box, or any hint, that says you have to restart codeblocks for the changes to work.
--- End quote ---
ollydbg:
--- Quote from: BlueHazzard on April 06, 2019, 02:25:48 pm ---Looks fine for me windows 7 and windows 10
wx30 (for the moment)
beside this:
--- Quote ---One thing that bothers me is that there is no message box, or any hint, that says you have to restart codeblocks for the changes to work.
--- End quote ---
--- End quote ---
I'm building the C::B rev11623 against wx git master(909adbb6bf832ada3db034cffc5548b8309a1602, note VZ has fix some toolbar related issue in the wx git master recent days, see discussion here: possible to make wxChoice a little shorter(smaller) inside wxToolbar - Google Groups), under mingw-w64's GCC 7.2 32bit compiler, the icon works fine! Thanks.
I think a "restart" hint should show up so people will restart C::B to let the change of icon take effect.
BTW, the dialog somehow shows some layout issue, but maybe, it is not C::B related, see image shot in attachment:
Miguel Gimenez:
--- Quote ---BTW, the dialog somehow shows some layout issue
--- End quote ---
That's due to the wxCB_SIMPLE flag being used in the combobox, removing it fixes the issue. I have attached a patch.
ollydbg:
--- Quote from: Miguel Gimenez on April 07, 2019, 08:51:49 pm ---
--- Quote ---BTW, the dialog somehow shows some layout issue
--- End quote ---
That's due to the wxCB_SIMPLE flag being used in the combobox, removing it fixes the issue. I have attached a patch.
--- End quote ---
Thanks Miguel Gimenez for the patch. It works fine on my system(wx master, which is wx 3.1.2).
OK to commit?
I currently don't have other wx library, I see the patch fixed the same issue under wxsmith's preview (in C::B prebuild against wx 3.1.1), does it cause regression other wx version, such as wx 2.8?
Navigation
[0] Message Index
[#] Next page
[*] Previous page
Go to full version