« previous next »
Pages: [1]   Go Down

Author Topic: Items that should not be translated in manager.cpp  (Read 7066 times)

Offline gd_on

  • Lives here!
  • ****
  • Posts: 824
Items that should not be translated in manager.cpp
« on: September 11, 2013, 07:10:17 pm »
In svn 9310, many items have been added in manager.cpp.
Most of them appears declared as _ strings, for example as name = _("cbEVT_APP_STARTUP_DONE").
The problem is that they appear as translatable strings, but should not I think.
They should probably be declared as _T strings, so name = _T("cbEVT_APP_STARTUP_DONE").

gd_on
Logged
Windows 11 64 bits (24H2), svn C::B (last version or almost!), wxWidgets 3.2.8 (tests with 3.3), Msys2 Compilers 15.1.0, 64 bits (seh, posix : gcc, g++ and gfortran in C:\msys64\mingw64) or 32 bits (dwarf2, posix  in C:\msys64\mingw32).

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 13406
    • Travis build status
Re: Items that should not be translated in manager.cpp
« Reply #1 on: September 11, 2013, 07:13:54 pm »
If you can do a patch it will be best :)
Logged
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline gd_on

  • Lives here!
  • ****
  • Posts: 824
Re: Items that should not be translated in manager.cpp
« Reply #2 on: September 11, 2013, 07:36:48 pm »
Here it is ...

gd_on
Logged
Windows 11 64 bits (24H2), svn C::B (last version or almost!), wxWidgets 3.2.8 (tests with 3.3), Msys2 Compilers 15.1.0, 64 bits (seh, posix : gcc, g++ and gfortran in C:\msys64\mingw64) or 32 bits (dwarf2, posix  in C:\msys64\mingw32).

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 13406
    • Travis build status
Re: Items that should not be translated in manager.cpp
« Reply #3 on: September 11, 2013, 11:35:45 pm »
in svn...
Logged
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline ollydbg

  • Developer
  • Lives here!
  • *****
  • Posts: 6079
  • OpenCV and Robotics
    • Chinese OpenCV forum moderator
Re: Items that should not be translated in manager.cpp
« Reply #4 on: September 12, 2013, 02:34:44 am »
Thank to gd_on and OBF.
Commit 9310 is again my fault, sorry about that.
Logged
If some piece of memory should be reused, turn them to variables (or const variables).
If some piece of operations should be reused, turn them to functions.
If they happened together, then turn them to classes.
Pages: [1]   Go Up
« previous next »