Author Topic: Tab Save/SaveAll fix maybe??  (Read 19301 times)

Offline Urxae

  • Regular
  • ***
  • Posts: 376
Re: Tab Save/SaveAll fix maybe??
« Reply #15 on: December 20, 2005, 08:24:36 pm »
Allthough mathematically 1 ∈ all, it really only makes sense to enable "all" if n > 1. Else, we don't need "save".

Imagine the following situation: You have a lot of editors open. One of them is modified (or maybe you're not sure if any are modified). Unfortunately, it's not the current one, and the modified one is not visible in the row of tabs at the top of the screen. You now either have to scroll the tab list1 or use the open files list2 to get to the tab and hit "Save".
Wouldn't it be easier to just hit Ctrl-Shift-S to "Save all"? Wouldn't it make sense for that option to be enabled then?
Besides, I've never seen a multi-document interface that didn't allow you to "Save all" if there's only one document modified. (I've seen some take the easy route and never disable "Save all", though)

Of course, I might not even notice, since the only time I ever need to save anything is right before a build, when it happens automatically ;).

1) And possibly guess which way to scroll if both directions are possible.
2) Which is rather small, at least for me. The project view is usually more important to me.

Offline Pecan

  • Plugin developer
  • Lives here!
  • ****
  • Posts: 2873
Re: Tab Save/SaveAll fix maybe??
« Reply #16 on: December 20, 2005, 08:28:08 pm »
Note that the left hand editor tab has been modified,  but neither
save nor save all is enabled, because I right clicked on an unmodified
editor/tab.

This is because modified>1 is false

thanks
pecan


[attachment deleted by admin]
« Last Edit: December 20, 2005, 08:30:46 pm by Pecan »

Offline thomas

  • Administrator
  • Lives here!
  • *****
  • Posts: 3979
Re: Tab Save/SaveAll fix maybe??
« Reply #17 on: December 20, 2005, 08:28:16 pm »
Imagine the following situation: You have a lot of editors open. One of them is modified (or maybe you're not sure if any are modified). Unfortunately, it's not the current one, and the modified one is not visible
Imagine you have two or three modified... you don't want to do this. It is russian roulette.
"We should forget about small efficiencies, say about 97% of the time: Premature quotation is the root of public humiliation."

Offline Urxae

  • Regular
  • ***
  • Posts: 376
Re: Tab Save/SaveAll fix maybe??
« Reply #18 on: December 20, 2005, 08:36:16 pm »
Imagine the following situation: You have a lot of editors open. One of them is modified (or maybe you're not sure if any are modified). Unfortunately, it's not the current one, and the modified one is not visible
Imagine you have two or three modified... you don't want to do this. It is russian roulette.

Imagine you actually want to (*gasp*) save all your changes, but the only way to make sure there isn't a lone unmodified tab is to scroll through and look at all the tabs...

Offline thomas

  • Administrator
  • Lives here!
  • *****
  • Posts: 3979
Re: Tab Save/SaveAll fix maybe??
« Reply #19 on: December 20, 2005, 08:46:28 pm »
What's the problem? If you have two or more modified documents and you really want to save all, you can just use "save all".

But you should know that "all" means "more than one". If "one" and "all" is the same, you can save several documents when in fact you don't want to do that.
"We should forget about small efficiencies, say about 97% of the time: Premature quotation is the root of public humiliation."

Offline Pecan

  • Plugin developer
  • Lives here!
  • ****
  • Posts: 2873
Re: Tab Save/SaveAll fix maybe??
« Reply #20 on: December 20, 2005, 08:54:02 pm »
Maybe we should take this code out of core and go back to the
TabSave plugin with a lot of config options that could please everyone.
People could define their own save/saveall behavior

thanks
pecan

Offline rickg22

  • Lives here!
  • ****
  • Posts: 2283
Re: Tab Save/SaveAll fix maybe??
« Reply #21 on: December 20, 2005, 08:56:00 pm »
Thomas: Allow me to express an opinion on Microsoft products.

DO *NOT* EVER take decisions for the users! It's acceptable to provide some guidance for joe-users, but hindering power users is a big no-no. If the user wants to save all, let him. If he screws up, it's his fault, not ours.

We don't want to walk in the big M's footsteps, do we?

As for me, I agree with Urxae.

Offline Pecan

  • Plugin developer
  • Lives here!
  • ****
  • Posts: 2873
Re: Tab Save/SaveAll fix maybe??
« Reply #22 on: December 20, 2005, 08:59:34 pm »
I too would rather have "save" enabled if the editor/tab
clicked on has been modified.

I would rather have "saveall" enabled if *any* file
has been modified.

Having them enabled like this also raises a flag when
the tab is out of eye range.

Edit: also, having saveAll disabled when only "this"
file has been modified shows that I dont have to worry
about other (unseen) tabs.

thanks
pecan
« Last Edit: December 20, 2005, 09:04:19 pm by Pecan »

Offline thomas

  • Administrator
  • Lives here!
  • *****
  • Posts: 3979
Re: Tab Save/SaveAll fix maybe??
« Reply #23 on: December 20, 2005, 09:19:56 pm »
I don't use the tab menu anyway, and if you absolutely wish to shoot your foot... I care not.
But this was the last time I modify editormanager today... :lol:
"We should forget about small efficiencies, say about 97% of the time: Premature quotation is the root of public humiliation."

Offline rickg22

  • Lives here!
  • ****
  • Posts: 2283
Re: Tab Save/SaveAll fix maybe??
« Reply #24 on: December 21, 2005, 03:13:52 am »
lol :P Anyway, thanks. Tonight i'm compiling C::B and copying it to my flash drive so i can keep working while i'm on vacations :) Yay! :D