Developer forums (C::B DEVELOPMENT STRICTLY!) > Compiler Framework Redesign
XML based compilers
Alpha:
--- Quote from: MortenMacFly on October 09, 2012, 07:12:38 am ---Wouldn't the wxWidgets bug-tracker be the right place to report?!
--- End quote ---
I actually was not quite sure where it belonged. I will submit it there as well. (It appears that this was reported a while ago as well.)
Alpha:
About rev. 8553, would the following be more friendly for translators? Or should this type of pseudo-intelligent logging be avoided?
--- Code: ---Index: src/plugins/compilergcc/compilergcc.cpp
===================================================================
--- src/plugins/compilergcc/compilergcc.cpp (revision 8554)
+++ src/plugins/compilergcc/compilergcc.cpp (working copy)
@@ -3728,8 +3728,9 @@
wxString CompilerGCC::GetErrWarnStr()
{
- return wxString::Format(_("%u error(s), %u warning(s)"),
- m_Errors.GetCount(cltError), m_Errors.GetCount(cltWarning));
+ return wxString::Format(_("%u %s, %u %s"),
+ m_Errors.GetCount(cltError), wxString(m_Errors.GetCount(cltError) == 1 ? _("error") : _("errors")).wx_str(),
+ m_Errors.GetCount(cltWarning), wxString(m_Errors.GetCount(cltWarning) == 1 ? _("warning") : _("warnings")).wx_str());
}
wxString CompilerGCC::GetMinSecStr()
@@ -3737,6 +3738,7 @@
long int elapsed = (wxGetLocalTimeMillis() - m_StartTime).ToLong() / 1000;
int mins = elapsed / 60;
int secs = (elapsed % 60);
- return wxString::Format(_("%d minute(s), %d second(s)"), mins, secs);
-;
+ return wxString::Format(_("%d %s, %d %s"),
+ mins, wxString(mins == 1 ? _("minute") : _("minutes")).wx_str(),
+ secs, wxString(secs == 1 ? _("second") : _("seconds")).wx_str());
}
Index: src/plugins/compilergcc/directcommands.cpp
===================================================================
--- src/plugins/compilergcc/directcommands.cpp (revision 8554)
+++ src/plugins/compilergcc/directcommands.cpp (working copy)
@@ -613,8 +613,8 @@
if (!fileMissing.IsEmpty())
{
wxString warn;
- warn.Printf(_("WARNING: Target '%s': Unable to resolve %lu external dependenc%s:"),
- target->GetFullTitle().wx_str(), static_cast<unsigned long>(fileMissing.Count()), wxString(fileMissing.Count() == 1 ? _("y") : _("ies")).wx_str());
+ warn.Printf(_("WARNING: Target '%s': Unable to resolve %lu external %s:"),
+ target->GetFullTitle().wx_str(), static_cast<unsigned long>(fileMissing.Count()), wxString(fileMissing.Count() == 1 ? _("dependency") : _("dependencies")).wx_str());
ret.Add(wxString(COMPILER_SIMPLE_LOG) + warn);
for (size_t i=0; i<fileMissing.Count(); i++)
ret.Add(wxString(COMPILER_SIMPLE_LOG) + fileMissing[i]);
--- End code ---
oBFusCATed:
I see no problem with the current version ... KISS for the win.
MortenMacFly:
--- Quote from: oBFusCATed on November 12, 2012, 11:53:08 pm ---I see no problem with the current version ... KISS for the win.
--- End quote ---
I agree. Either we do it like that in all places or we just keep it simple. It has some more advantages: You don't have to translate many units. Already now we have several thousands of units to translate anyways - adding even more might not be the best thing to do you know... ;)
@Alpha: If you want to, make a poEdit session on Code::Blocks. Then you know what I am talking about... ;D
However - you pointed me to a place that I missed to simplify. :P
Alpha:
I think this might be a side effect from having an overzealous English teacher :).
--- Quote from: MortenMacFly on November 13, 2012, 08:58:19 am ---@Alpha: If you want to, make a poEdit session on Code::Blocks. Then you know what I am talking about... ;D
--- End quote ---
I can imagine :o (and I have enough trouble as it is when I need to translate just a few sentences).
Navigation
[0] Message Index
[#] Next page
[*] Previous page
Go to full version