break "filename:line" will not work in the futher gdb

[ollydbg]

Hi, OBF, see this post:
http://sourceware.org/ml/gdb-patches/2012-03/msg00823.html

I have some discussion with gdb developers, and after the line specification rewrite, the command break "filename:line" will not work anymore, can we use this command with out "quotes" like:

Code

break "filename":line
or
break filename:line

I think it was easy to change in debugger plugin, right?

[ollydbg]

It this the only place I have to change? in file: gdb_commands.h

Code

class GdbCmd_AddBreakpoint : public DebuggerCmd
{
        DebuggerBreakpoint::Pointer m_BP;
    public:
        /** @param bp The breakpoint to set. */
        GdbCmd_AddBreakpoint(DebuggerDriver* driver, DebuggerBreakpoint::Pointer bp)
            : DebuggerCmd(driver),
            m_BP(bp)
        {
            // gdb doesn't allow setting the bp number.
            // instead, we must read it back in ParseOutput()...
            m_BP->index = -1;

            if (m_BP->enabled)
            {
                if (m_BP->type == DebuggerBreakpoint::bptCode)//m_BP->func.IsEmpty())
                {
                    wxString out = m_BP->filename;
                    // we add one to line,  because scintilla uses 0-based line numbers, while gdb uses 1-based
                    if (!m_BP->temporary)
                        m_Cmd << _T("break ");
                    else
                        m_Cmd << _T("tbreak ");
                    m_Cmd << _T('"') << out << _T(":") << wxString::Format(_T("%d"), m_BP->line) << _T('"');

[oBFusCATed]

Probably.
What version of gdb has this feature? 7.4?

[ollydbg]

Probably.

I just remove the double-quote in the break command, and now setting bp works OK under c::b, but it looks like the removing bp works badly, maybe, the parsing output method should be changed also.

What version of gdb has this feature? 7.4?

This new feature is tested by one gdb developer(in his git gdb branch), I think it will be merged to the main trunk some days later. gdb 7.4 has already released(they won't add any new feature in the 7.4 branch), so I believe it will happen in gdb 7.5.

EDIT: As the change will break many IDE front end, I think there will be further discussions in gdb maillist.

[oBFusCATed]

If it is not an official release, you're on your own, sorry. No time to support random gdb-testing-versions.

[ollydbg]

If it is not an official release, you're on your own, sorry. No time to support random gdb-testing-versions.

Ok, never mind.
I will follow the discussions in gdb maillist, and response if the break command has changed.
Thanks.

PS: I'm looking forward to test/try your gdb mi plugin when they are ready. 

[oBFusCATed]

You can get it for here: svn://cmpt.benbmp.org/cb_gdb_mi
It should be relatively usable.

[thomas]

Does "filename":line not make a lot more sense anyway, even now? That's assuming the current version supports that, of course.

If the present version supports this variant, I don't see why we should not use it. A line number should not contain anything that needs quoting, only a filename might. Insofar, only quoting the filename is a kind of sensible approach.

[ollydbg]

Does "filename":line not make a lot more sense anyway, even now? That's assuming the current version supports that, of course.

If the present version supports this variant, I don't see why we should not use it. A line number should not contain anything that needs quoting, only a filename might. Insofar, only quoting the filename is a kind of sensible approach.

The gdb developer Keith strongly suggest that the line number should not be quoted.
This feature "filename":line does not exist in the current gdb CVS or 7.4 branch, but I guess they still need some test. (Currently, the new line specification has already pass all the gdb build-in tests)

Change our debugger branch code is quite simple. For the

Code

break filename:line

Here is the patch:

Code

Index: E:/code/cb/cb_debugger_branch/src/plugins/debuggergdb/gdb_commands.h
===================================================================
--- E:/code/cb/cb_debugger_branch/src/plugins/debuggergdb/gdb_commands.h	(revision 7909)
+++ E:/code/cb/cb_debugger_branch/src/plugins/debuggergdb/gdb_commands.h	(working copy)
@@ -131,7 +131,7 @@
 // Breakpoint 1 at 0x4013d6: file main.cpp, line 8.
 static wxRegEx reBreakpoint(_T("Breakpoint ([0-9]+) at (0x[0-9A-Fa-f]+)"));
 // Breakpoint 1 ("/home/jens/codeblocks-build/codeblocks-1.0svn/src/plugins/debuggergdb/gdb_commands.h:125) pending.
-static wxRegEx rePendingBreakpoint(_T("Breakpoint ([0-9]+)[ \t]\\(\\\"(.+):([0-9]+)\\)[ \t]pending\\."));
+static wxRegEx rePendingBreakpoint(_T("Breakpoint ([0-9]+)[ \t]\\((.+):([0-9]+)\\)[ \t]pending\\."));
 // Hardware assisted breakpoint 1 at 0x4013d6: file main.cpp, line 8.
 static wxRegEx reHWBreakpoint(_T("Hardware assisted breakpoint ([0-9]+) at (0x[0-9A-Fa-f]+)"));
 // Hardware watchpoint 1: expr
@@ -448,7 +448,7 @@
                         m_Cmd << _T("break ");
                     else
                         m_Cmd << _T("tbreak ");
-                    m_Cmd << _T('"') << out << _T(":") << wxString::Format(_T("%d"), m_BP->line) << _T('"');
+                    m_Cmd << out << _T(":") << wxString::Format(_T("%d"), m_BP->line);
                 }
                 else if (m_BP->type == DebuggerBreakpoint::bptData)
                 {

This patch works under both the official gdb or the gdb-line-spec-branch.

For

Code

break "filename":line

It should also be quite easy to implement.

To my point: I think mostly quote is not needed. (I exclude the case that file name does not contain spaces  , I'm not sure gdb support this)

[oBFusCATed]

The quote was added because some people have their projects inside paths containing "code::blocks" and this is regarded as method/function specification.

[ollydbg]

The quote was added because some people have their projects inside paths containing "code::blocks" and this is regarded as method/function specification.

Ok, thanks, here is the new test from command line(under c::b debugger plugin)

Code

[debug]> break "E:/code/cb/test_code/DebugDLLTest/TestDLL/dllmain1.cpp":29
[debug]No source file named E:/code/cb/test_code/DebugDLLTest/TestDLL/dllmain1.cpp.
[debug]Breakpoint 6 ("E:/code/cb/test_code/DebugDLLTest/TestDLL/dllmain1.cpp":29) pending.
[debug]>>>>>>cb_gdb:

No source file named E:/code/cb/test_code/DebugDLLTest/TestDLL/dllmain1.cpp.
Breakpoint 6 ("E:/code/cb/test_code/DebugDLLTest/TestDLL/dllmain1.cpp":29) pending.
> break "E:/code/cb/test_code/DebugDLLTest/TestDLL/dllmain.cpp":35

[debug]> break "E:/code/cb/test_code/DebugDLLTest/TestDLL/dllmain.cpp":35
[debug]Breakpoint 7 at 0x684c1814: file E:\code\cb\test_code\DebugDLLTest\TestDLL\dllmain.cpp, line 35.
[debug]>>>>>>cb_gdb:

Breakpoint 7 at 0x684c1814: file E:\code\cb\test_code\DebugDLLTest\TestDLL\dllmain.cpp, line 35.

So, I'm now trying to adjust the reg.

[oBFusCATed]

So, I'm now trying to adjust the reg.

Good luck...

[ollydbg]

So, I'm now trying to adjust the reg.

Good luck...

Thanks, Done. Here is the new regular expression and patch:

Code

Index: E:/code/cb/cb_debugger_branch/src/plugins/debuggergdb/gdb_commands.h
===================================================================
--- E:/code/cb/cb_debugger_branch/src/plugins/debuggergdb/gdb_commands.h	(revision 7909)
+++ E:/code/cb/cb_debugger_branch/src/plugins/debuggergdb/gdb_commands.h	(working copy)
@@ -131,7 +131,7 @@
 // Breakpoint 1 at 0x4013d6: file main.cpp, line 8.
 static wxRegEx reBreakpoint(_T("Breakpoint ([0-9]+) at (0x[0-9A-Fa-f]+)"));
 // Breakpoint 1 ("/home/jens/codeblocks-build/codeblocks-1.0svn/src/plugins/debuggergdb/gdb_commands.h:125) pending.
-static wxRegEx rePendingBreakpoint(_T("Breakpoint ([0-9]+)[ \t]\\(\\\"(.+):([0-9]+)\\)[ \t]pending\\."));
+static wxRegEx rePendingBreakpoint(_T("Breakpoint ([0-9]+)[ \t]\\(\\\"(.+)\\\":([0-9]+)\\)[ \t]pending\\."));
 // Hardware assisted breakpoint 1 at 0x4013d6: file main.cpp, line 8.
 static wxRegEx reHWBreakpoint(_T("Hardware assisted breakpoint ([0-9]+) at (0x[0-9A-Fa-f]+)"));
 // Hardware watchpoint 1: expr
@@ -448,7 +448,7 @@
                         m_Cmd << _T("break ");
                     else
                         m_Cmd << _T("tbreak ");
-                    m_Cmd << _T('"') << out << _T(":") << wxString::Format(_T("%d"), m_BP->line) << _T('"');
+                    m_Cmd << _T('"') << out << _T("\":") << wxString::Format(_T("%d"), m_BP->line);
                 }
                 else if (m_BP->type == DebuggerBreakpoint::bptData)
                 {

[ollydbg]

FYI:
The command:

Code

break "filename:line" 

is reserved for compatibility.

In the future, the gdb bp pending response will have quote balance.

See:Re: [RFA 1/2] Linespec rewrite (update 2)

[ollydbg]

Again. The new linespec feature is now in GDB CVS HEAD, which means it will be official in GDB 7.5 (It also support using filename with spaces). I think we need to adjust the regex a little to support the new pattern and also keep the old GDB compatible. This should be easy.