« previous next »
Pages: [1]   Go Down

Author Topic: Why wxSmith is dependency for other plugins?  (Read 8438 times)

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 13406
    • Travis build status
Why wxSmith is dependency for other plugins?
« on: October 03, 2011, 11:20:16 am »
Why are we building the wxsmith plugins as dependency for other plugins (ThreadSearch, libfinder, etc)?

I'm having problems compiling the wxsmith on Fedora8+wxGTK 2.8.9 and I've tried to disable all wxSmith plugins.
Unfortunately the plugin is still built.

Probably we should fail the configure step if wxSmith is disabled and ThreadSearch/libfinder is enabled.
Jens, what do you think on this matter?
Logged
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline ollydbg

  • Developer
  • Lives here!
  • *****
  • Posts: 6077
  • OpenCV and Robotics
    • Chinese OpenCV forum moderator
Re: Why wxSmith is dependency for other plugins?
« Reply #1 on: October 03, 2011, 11:40:25 am »
I just look at the dependency on threadsearch plugin in ContribPlugins.workspace, I found that it depend on wxCustombutton, and wxCustombutton is include in wxSmithContribItems project.
Logged
If some piece of memory should be reused, turn them to variables (or const variables).
If some piece of operations should be reused, turn them to functions.
If they happened together, then turn them to classes.

Offline Jenna

  • Administrator
  • Lives here!
  • *****
  • Posts: 7252
Re: Why wxSmith is dependency for other plugins?
« Reply #2 on: October 03, 2011, 11:53:20 am »
Quote from: ollydbg on October 03, 2011, 11:40:25 am
I just look at the dependency on threadsearch plugin in ContribPlugins.workspace, I found that it depend on wxCustombutton, and wxCustombutton is include in wxSmithContribItems project.
And that needs wxSmith.
That's the cause for the dependency.
And similar for libfinder: it uses wxFlatNotebook.

Both automatically select wxSmith and wxSmithContribItems to build in automake-system.
Logged

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 13406
    • Travis build status
Re: Why wxSmith is dependency for other plugins?
« Reply #3 on: October 03, 2011, 12:20:19 pm »
OK, as we know the problem how would we fix it?
Probably fixing configure is the first step, but this situation looks like wrong setup of dependencies.
As long term, correct solution, we should move the wx-related-libs in the src/plugins/contrib/wxlibs (or something similar).
And then the dependencies will be correct and logical.
What do you think?

Logged
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline Jenna

  • Administrator
  • Lives here!
  • *****
  • Posts: 7252
Re: Why wxSmith is dependency for other plugins?
« Reply #4 on: October 03, 2011, 02:16:05 pm »
Quote from: oBFusCATed on October 03, 2011, 12:20:19 pm
As long term, correct solution, we should move the wx-related-libs in the src/plugins/contrib/wxlibs (or something similar).
And then the dependencies will be correct and logical.
What do you think?
Moving all contrib-items into a seperate project and use it as dependency for wxSmithConribItems, would be the best solution in my opinion.
Not only as long term solution, but also as short term solution.

I can do it this week (no work) and fix all related projects, if no other devs have objections against it.

We should do the same (or similar) for all new items in the wxSmith-branch, too.
Logged

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 13406
    • Travis build status
Re: Why wxSmith is dependency for other plugins?
« Reply #5 on: October 03, 2011, 02:40:28 pm »
No objections  :lol:
Logged
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 13406
    • Travis build status
Re: Why wxSmith is dependency for other plugins?
« Reply #6 on: October 03, 2011, 02:45:34 pm »
BTW: any objections against committing this patch: http://smrt.is-a-geek.org/codeblocks/patches/wx289.patch
Logged
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline MortenMacFly

  • Administrator
  • Lives here!
  • *****
  • Posts: 9723
Re: Why wxSmith is dependency for other plugins?
« Reply #7 on: October 06, 2011, 07:22:01 am »
Logged
Compiler logging: Settings->Compiler & Debugger->tab "Other"->Compiler logging="Full command line"
C::B Manual: https://www.codeblocks.org/docs/main_codeblocks_en.html
C::B FAQ: https://wiki.codeblocks.org/index.php?title=FAQ

Offline Jenna

  • Administrator
  • Lives here!
  • *****
  • Posts: 7252
Re: Why wxSmith is dependency for other plugins?
« Reply #8 on: October 06, 2011, 05:32:17 pm »
I did it for trunk on linux (project-files and automake), seems to work.
I hope I find the time to do it for windows this evening or tomorrow.
The new project is called wxContribItems and builds wxFlatNotebook, wxChartCtrl and wxCustomButton.
Logged

Offline Jenna

  • Administrator
  • Lives here!
  • *****
  • Posts: 7252
Re: Why wxSmith is dependency for other plugins?
« Reply #9 on: November 06, 2011, 10:38:18 am »
The changes are committed to the wxsmith-branch.
More of them (for the new items in this branch) will follow.
Logged
Pages: [1]   Go Up
« previous next »