why does our build system fails when sdk_events changes

[killerbot]

Everytime when something changes (like adding new events) in sdk_events.h, the next build fails for me on all my linux boxes, I will always have to do make clean first.

I would assume it should work incrementally to, right ?
Here's last nights error :

Code

g++ -DHAVE_CONFIG_H -I. -I../../src/include -I/usr/lib64/wx/include/gtk2-unicode-release-2.8 -I/usr/include/wx-2.8 -D_FILE_OFFSET_BITS=64 -D_LARGE_FILES -D__WXGTK__ -pthread -I../../src/sdk/wxscintilla/include -I../../src/include -I../../src/include/scripting/include -I../../src/include/scripting/sqplus -I../../src/include/mozilla_chardet -DENABLE_BINRELOC -DAPP_PREFIX="\"/usr/local\"" -Ulinux -Uunix  -O2 -ffast-math -DCB_AUTOCONF -g -O2 -DCB_PRECOMP -Winvalid-pch -fPIC -DPIC -fexceptions -MT main.o -MD -MP -MF .deps/main.Tpo -c -o main.o main.cpp
main.cpp: In member function ‘void MainFrame::RegisterEvents()’:
main.cpp:614:27: error: ‘cbEVT_HIDE_LOG_WINDOW’ was not declared in this scope
main.cpp:616:27: error: ‘cbEVT_GET_ACTIVE_LOG_WINDOW’ was not declared in this scope

Might it be those nice precompiled headers ?

[MortenMacFly]

Might it be those nice precompiled headers ?

Yes, certainly. It should therefoe be enough to delete the (two) PCH files. 'However, this kind of forces a re-compilation, too as the date of the PCH file has changed... ;-)

[killerbot]

agreed, but why is the 'rebuild' which is needed for the pch not triggered by the system. Now it first build for a while to pop up with an error, and then we have to have the reflex, might by related to pch, let's do make clean or delete the pch's.

My worry is : we should not have to care about that, the system should do what is needed, and ok, we will notice since the build will take a whole lot longer ;-)

[Folco]

I agree ! I had to do a make clean between svn 6900 and svn 6922, and it's not the first time it happened !

[killerbot]

Once again, this is happening. I have the feeling it gas become a real pain the last couple of weeks, just like something died on the inside :

For example : Rev 6945 on the debugger branch (the same happened also on main, and there I also suffered this problem) : cbauibook.h got changed, together with some other files.
Build the system (aka make, so not make clean && make) :

Code

g++ -DHAVE_CONFIG_H -I. -I../../src/include -I/usr/lib64/wx/include/gtk2-unicode-release-2.8 -I/usr/include/wx-2.8 -D_FILE_OFFSET_BITS=64 -D_LARGE_FILES -D__WXGTK__ -pthread -I../../src/sdk/wxscintilla/include -I../../src/include -I../../src/include/scripting/include -I../../src/include/scripting/sqplus -I../../src/include/mozilla_chardet -DENABLE_BINRELOC -DAPP_PREFIX="\"/usr/local\"" -Ulinux -Uunix  -O2 -ffast-math -DCB_AUTOCONF -g -O2 -DCB_PRECOMP -Winvalid-pch -fPIC -DPIC -fexceptions -MT environmentsettingsdlg.o -MD -MP -MF .deps/environmentsettingsdlg.Tpo -c -o environmentsettingsdlg.o environmentsettingsdlg.cpp
environmentsettingsdlg.cpp: In member function ‘virtual void EnvironmentSettingsDlg::EndModal(int)’:
environmentsettingsdlg.cpp:548:9: error: ‘AllowScrolling’ is not a member of ‘cbAuiNotebook’
environmentsettingsdlg.cpp:549:47: error: cannot call member function ‘void cbAuiNotebook::UseToolTips(bool)’ without object
environmentsettingsdlg.cpp:550:91: error: cannot call member function ‘void cbAuiNotebook::SetDwellTime(long int)’ without object
environmentsettingsdlg.cpp:551:9: error: ‘SetModKeys’ is not a member of ‘cbAuiNotebook’
environmentsettingsdlg.cpp:552:9: error: ‘UseModToAdvance’ is not a member of ‘cbAuiNotebook’

environmentsettingsdlg.cpp will get the include of cbauibook.h through sdk.h, but it seems those darn pch's will never ever work correctly :-(

I have a feeling that we used to run into such issues from time to time, but currently it is nearly always ...

Did we break something ?

[Jenna]

It seems to work for me here.

(Re)building the pch's should only fail if a needed headerfile is missing from the ALLHEADERS-target.

Could you check the file permissions and the timestamp(s) ?

At least make clean should delete the pch's in any case.