Isn't it better to use control->GetForegroundColour()/GetBackgroundColour()?
Yeah it might. I wrote this quickly and I'm not familiar with wxWidgets.
Of course it should be tested, but this is a small change, which wouldn't need a long time to test. And it's not something that changes any critical internals either, so I'd say now is as good a time to fix this than ever. I'm not a Code::Blocks developer though...
It is not so easy to test it, because there are lots of gtk2 themes + windows xp/vista/7...
Ok, this might be true for the "brightening" of colors (the BlendTextColour function). But when choosing default theme colors for background and text, one can't really do anything wrong? In any case, choosing black for the foreground and leaving the background to the theme, as it was done e. g. in the search result logger, is about the worst combination one could do, no?
This article is about web pages, but I think it applies here too: "If You Pick One Color, Pick Them All"
http://www.w3.org/QA/Tips/colorMaybe we could agree on using GetXgroundColor() or wxSystemSettings::GetColour() for default text in loggers for now, and find a way to create contrasting warning/error messages later? Meaning, simple Red and Blue contrast pretty much any colour, so we can leave them as they are for now. Would be a step in the right direction IMHO.
If you don't want to do this, at least force the background colors to white. Even if that hurts my eyes ;o)