Author Topic: ThreadSearch build dependency  (Read 4758 times)

Offline ollydbg

  • Developer
  • Lives here!
  • *****
  • Posts: 6077
  • OpenCV and Robotics
    • Chinese OpenCV forum moderator
ThreadSearch build dependency
« on: October 05, 2009, 04:39:25 am »
Jens and other devs.

After a clean check out of the trunk code.

If you open the "ContribPlugins.workspace", and only choose one project "Threadsearch" to build, you will notice that the "wxCustombutton library" was lost.

So, I think the "threadSearch"  plugin should add  a dependency to wxSmithContribItems plugin.

thanks.
If some piece of memory should be reused, turn them to variables (or const variables).
If some piece of operations should be reused, turn them to functions.
If they happened together, then turn them to classes.

Offline Jenna

  • Administrator
  • Lives here!
  • *****
  • Posts: 7252
Re: ThreadSearch build dependency
« Reply #1 on: October 05, 2009, 07:23:40 am »
I committed such a change (dependencies on wxWmithContribItems for ThreadSearch- and LibFinder-plugin and dependency on wxSmith for wxWmithContribItems).

But I only committed the changes (wxCustomButton instead of wxBitmapButton) to trunk.
The dependencies might have been lost with the later merges of scintilla and debugger-propgrid-branch.

I have no access to svn.berlios.de at the moment (at least no authenticated access), so I can not check it and correct if necessary.

I hope the server will be up later the day (the berlios status-monitor still says it has a socket-timeout after 10 seconds on svn.berlios.de).

Offline Jenna

  • Administrator
  • Lives here!
  • *****
  • Posts: 7252
Re: ThreadSearch build dependency
« Reply #2 on: October 06, 2009, 12:21:29 am »
As far as I can see trunk, scintilla- and dbg-/propgrid-testbranch have the dependencies set correctly.

Offline ollydbg

  • Developer
  • Lives here!
  • *****
  • Posts: 6077
  • OpenCV and Robotics
    • Chinese OpenCV forum moderator
Re: ThreadSearch build dependency
« Reply #3 on: October 06, 2009, 03:56:22 am »
As far as I can see trunk, scintilla- and dbg-/propgrid-testbranch have the dependencies set correctly.

Thanks, I also confirm this.
I just do a testing on trunk code, the dependencies works.  :D
If some piece of memory should be reused, turn them to variables (or const variables).
If some piece of operations should be reused, turn them to functions.
If they happened together, then turn them to classes.