Old Toolbar Colour Bug is Back Again

[BigAngryDog]

I just switched Windows themes and noticed that a bug previously fixed moths ago has re-appeared.

This is the one where the toolbars display incorrect colours - mix between the colour scheme at install time and the new colour scheme.

[BigAngryDog]

Original thread detailing problem & fix:

http://forums.codeblocks.org/index.php?PHPSESSID=ac6c65e06a3fc698158a112d8c96903f&topic=3253.0

Screenie:

[MortenMacFly]

Original thread detailing problem & fix:

What happens if you re-run C::B and have the config file (temporarily) removed - thus C::B initialises from scratch?
With regards, Morten.

[BigAngryDog]

>What happens if you re-run C::B and have the config file (temporarily) remove

Just tried it--and CB shows the current colours correctly. So it seems that the current Windows system colour values are being stored in the config file when it is first created.

System colours are dynamic and maybe changed at any time. Should CB be storing these?

[MortenMacFly]

System colours are dynamic and maybe changed at any time. Should CB be storing these?

Sure it should - you can adjust them inside C::B. Ever seen an adjustable feature that not get's stored...?! ;-)

[BigAngryDog]

>Sure it should - you can adjust them inside C::B.

In this case, C::B should be using it's own colours as specified in the environment settings.

The problem is that it is using a mix of current windows colours and C::B specific environment colours. These CB colours were one-time initialised to the system colours when C::B first ran, but when the system colours change, the result is a mash between the two.

Also, would it be possible to have a check box in the colour settings page to specify "Follow System Colors"?

[mandrav]

Please understand that this is an issue of wxAUI. All toolbars are managed by it and C::B has no other code that messes with the toolbar colors.

[mandrav]

I have removed the relevant colour settings so it now uses always the active theme's colours.
In short, bug fixed .

[BigAngryDog]

Good stuff!

[afb]

I have removed the relevant colour settings so it now uses always the active theme's colours.
In short, bug fixed .

Thanks for doing this, it makes it look a lot better on Mac OS X too!

It used to have a "white area" like this:

Now it is all "grey" just like it should be.