Developer forums (C::B DEVELOPMENT STRICTLY!) > Development
Debugger breakpoints issue (again)
MortenMacFly:
--- Quote from: gschafra on June 08, 2006, 05:21:14 pm ---
--- Quote ---To sum up: WELL DONE!!!
--- End quote ---
Oh, thanks. But it seems that this "fix" messes up more than it fixes.
--- End quote ---
No, mandrav's corrections were good. This is indeed an issue with the underlying wxScintilla which mandrav corrected in a fully acceptable way. Anyway, what occurs now is a different problem. This hasn't been taken care of so far at all. Do you have another idea how to fix that? Patches are always welcome but please keep in mind that sometimes there are better solution. (I somehow got the feeling you are unhappy your patch hasn't been applied...?!)
With regards, Morten.
taZDeVil:
--- Quote from: MortenMacFly on June 08, 2006, 05:59:45 pm ---... (I somehow got the feeling you are unhappy your patch hasn't been applied...?!) ...
--- End quote ---
Ups, some misunderstanding. With the messing up fixes i meant mine not mandravs. I've already tested latter, but there seem to be still problems when deleting/cutting marked lines (with marking extended to EOT). Will take a quick glance on it....
taZDeVil:
--- Quote from: MortenMacFly on June 08, 2006, 04:12:46 pm ---Edit: Another case:
- set BP's at e.g. the last 3 lines of a file
- select the last 4 lines of the file
- press DEL, notice the BP's are NOT removed
I think this is related to the problem above, but just to make sure it's considered. Is there a way to get all registered BP's of a file? I only found {Add/Remove/Toggle}Breakpoint in the driver...?!
--- End quote ---
Here's another attempt to fix the issue of non removed debugger breakpoints if a block of lines is deleted. The patch:
Index: cbeditor.cpp
===================================================================
--- cbeditor.cpp (revision 2551)
+++ cbeditor.cpp (working copy)
@@ -2105,6 +2105,13 @@
int origstartline = m_pControl->LineFromPosition(event.GetPosition());
int startline = origstartline;
+ // when removing blocks of lines (linesAdded < -1) also remove all affected breakpoints
+ for (int i=startline ; (linesAdded < -1 && i < (startline - linesAdded)) ; i++)
+ {
+ debugger->RemoveBreakpoint(m_Filename, i);
+ // Manager::Get()->GetMessageManager()->DebugLog(_T("Removed breakpoint from line %d"), i );
+ }
+
// HACK, part1:
// ok, here's a hack for scintilla's bad behaviour with markers:
// if you press Enter on a line with a marker, scintilla doesn't move
If anyone could check this....
MortenMacFly:
--- Quote from: taZDeVil on June 12, 2006, 11:44:50 pm ---If anyone could check this....
--- End quote ---
Thanks! :D I've had a similar patch already in the pipeline (for testing). I guess we had the same idea somehow... anyway - it's in SVN now, feel free to do an update and test yourself.
With regards, Morten.
Navigation
[0] Message Index
[*] Previous page
Go to full version