Developer forums (C::B DEVELOPMENT STRICTLY!) > Development
Debugger breakpoints issue (again)
mandrav:
--- Quote from: mandrav on June 08, 2006, 02:18:37 pm ---
--- Quote from: gschafra on June 08, 2006, 11:15:44 am ---I think i solved the problem (*WHOOOO* my first constructive contribution).
--- End quote ---
Hmm, I don't know if your fix fixes an as-of-yet-unknown bug (will check shortly),
--- End quote ---
Checked and found no problem. Maybe my fix for the reported problem also fixed another bug you encountered?
MortenMacFly:
--- Quote from: mandrav on June 08, 2006, 02:18:37 pm ---Hmm, I don't know if your fix fixes an as-of-yet-unknown bug (will check shortly), but it has nothing to do with the reported bug.
--- End quote ---
I agree on that. Anyway, thanks for the help.
--- Quote from: mandrav on June 08, 2006, 02:18:37 pm ---Anyway, I 've fixed all breakpoint syncing issues when adding/removing lines in the editor (hopefully!).
--- End quote ---
Initially I wanted to say: "That's unfair!" because I was also still working on that one. Anyway, after looking at your solution I saw that we had at least the same idea, but your solution is still more clever than the one I was still implementing.
Anyway, I've done (nearly) all the tests that I had written down with all the special cases that can occure and guess what: Your code simply works. Just for a future reference here is what I had written down (for me) to test the breakpoints:
- (all tests usually for at least 3 lines of code)
- test for BP cases:
* only first line has a BP
* first+second line has a BP
* first+second+third line has a BP
* first+third line has a BP
- test for position cases:
* cursor within first line
* cursor within second line
* cursor within third line
- test for position of cursor within a line:
* position the cursor at the very beginning of the line
* position the cursor in the middle of a line
* position the cursor at the very end of the line
- test for paste-of-code cases:
* paste a single line of code
* paste two lines of code
* paste three lines of code
- test for del-of-code cases:
* del a single line of code
* del two lines of code
* del three lines of code
- test for insertion / deletion:
* insert: Press ENTER at the begining of a line
* insert: Press ENTER at the middle of a line
* insert: Press ENTER at the end of a line
* delete: mark a complete line (including "EOL"), press DEL
* delete: go to the end of a line, press DEL
- special cases:
* remove all characters of the file (CTRL+A;DEL)
* single line of code with not end of line marker
To sum up: WELL DONE!!! :P
With regards, Morten.
MortenMacFly:
--- Quote from: MortenMacFly on June 08, 2006, 04:10:09 pm ---- special cases:
* remove all characters of the file (CTRL+A;DEL)
--- End quote ---
...after writing this: This does not work yet -> all breakpoints remain in that case but they should all be removed... ;-)
With regards, Morten.
Edit: Another case:
- set BP's at e.g. the last 3 lines of a file
- select the last 4 lines of the file
- press DEL, notice the BP's are NOT removed
I think this is related to the problem above, but just to make sure it's considered. Is there a way to get all registered BP's of a file? I only found {Add/Remove/Toggle}Breakpoint in the driver...?!
killerbot:
:shock: :shock: I have the impression it still does not work :shock: :shock:
I checked the behaviour before and after todays commit, and it seems even worse then last week. Then some fixes were made (i tested also for this issue back then).
Tomorrow I will give some more elaborate details on what works and what not (have to go now).
[EDIT] : my test was now (different from last week) inserting/removing empty lines when the debugger hit a breakpoint, so quit something different ...
taZDeVil:
--- Quote ---To sum up: WELL DONE!!!
--- End quote ---
Oh, thanks. But it seems that this "fix" messes up more than it fixes.
--- Quote ---...after writing this: This does not work yet -> all breakpoints remain in that case but they should all be removed... Wink
With regards, Morten.
Edit: Another case:
- set BP's at e.g. the last 3 lines of a file
- select the last 4 lines of the file
- press DEL, notice the BP's are NOT removed
I think this is related to the problem above, but just to make sure it's considered. Is there a way to get all registered BP's of a file? I only found {Add/Remove/Toggle}Breakpoint in the driver...?!
--- End quote ---
This problem occurs if marked lines are deleted. There are currently no routines handling this.... oh... to late... mandrav commited some hacks....
Navigation
[0] Message Index
[#] Next page
[*] Previous page
Go to full version