Change to C++17?

[Miguel Gimenez]

There is an updated version of astyle library (3.6.18) that fixes some issues (see ticket 1643, but it uses the stupid C++17-only std::string_view and we currently are using C++11.

There is also some C++17-only code, like [fallthrough] in clangd_client, generating warnings.

Should we change to C++17?

[LETARTARE]

Have you tried to compile the full version with C++17 (Win-xx, Linux-xx) ?
If so, what warnings have you obtained ?

[LETARTARE]

Leap-15.6-64bits, wx-3.2.8;gtk3-u, gc-15.2
'r14003.cbp' ( no 'contrib' )
Here is the compilation log with 'C++17' :

[Miguel Gimenez]

Have you tried to compile the full version with C++17

I have not tried, developers must agree on the change beforehand. Changing the CBP is easy, the problem may come later from autotools.

Errors in Squirrel can be fixed, but it uses tricky memory accesses that may be a headache.

[gd_on]

Just to inform you that with my CodeBlocks_Windows.workspace, and setting my global variable cb_build.cpp_std to gnu++20, codeblocks compiles correctly as far as I have tested. Of course, this does not cover all build methods.

[christo]

Hi Miguel,

I've been using c++20 for a long time without any issues in my custom branch's  autotools build on ubuntu. I think we can upgrade to c++20 directly.

For autotools, following change should be sufficient : https://github.com/josephch/codeblocks/commit/c56d5feaf0ce0c5d511263d1fba29e3713af68e2

[Pecan]

I use wx2.3.8 and wx3.3.3 for CodeBlocks (all compiled at c++20) every day.

[Miguel Gimenez]

Should we use gnu++20 or plain c++20?

[christo]

I think plain c++20 should be okay as we do not use any gnu specific extensions.

Regarding squirrel warnings, looks like it is fixed upstream by casting : https://github.com/albertodemichelis/squirrel/commit/6ad6f6427157757c4431907dde0a1e5712a5cf67

[stahta01]

Remember to update the file from "https://www.gnu.org/software/autoconf-archive/ax_cxx_compile_stdcxx.html" in the "m4" folder.

The link above did not work searching found this link "https://github.com/autoconf-archive/autoconf-archive/blob/master/m4/ax_cxx_compile_stdcxx.m4"

[killerbot]

I am building the nightlies for a few weeks (?months) with -std=c++23.

I would suggest to step up to 23, and let's avoid extension, so I would suggest not to use 'gnu++xx'.

What do you think ?

[LETARTARE]

@christo :Thanks
Errors in Squirrel are removed by the indicated correction. (r14011)

[Miguel Gimenez]

Squirrel warning removed in r14013, thanks christo and LETARTARE.

[Miguel Gimenez]

My current development environment (MinGW8.1) only supports upto C++2a, I can change C::B to C++20 or C++23 but then I will be out of the game for a while...

[christo]

My current development environment (MinGW8.1) only supports upto C++2a, I can change C::B to C++20 or C++23 but then I will be out of the game for a while...

I think c++17 should be fine for now

[ollydbg]

I'm OK with C++17.

BTW: about the code repo, can we switch to git?