Author Topic: compiling error about autorevision because of space missing of contact git cmd  (Read 1687 times)

Offline kipade

  • Multiple posting newcomer
  • *
  • Posts: 51
As we known, cb's official repo is svn, and will generate version infomation from local svn repo directory. And, it still provide a method to generating such version form local git repo. But, the code miss a space character when contact a git command at build_tools/autorevision/autorevision.cpp:221:
Code
        if (GetProcessOutput(output, vcsExecutable + " log --grep=\"git-svn-id\" --max-count=1" + workingDir))
here, there should be a space character between "--max-count=1" and workingDir params.
Hope to fix it. Thanks

Offline ollydbg

  • Developer
  • Lives here!
  • *****
  • Posts: 5931
  • OpenCV and Robotics
    • Chinese OpenCV forum moderator
Hi, long time no see.

Yes, I think you are right. Thanks.
If some piece of memory should be reused, turn them to variables (or const variables).
If some piece of operations should be reused, turn them to functions.
If they happened together, then turn them to classes.

Offline kipade

  • Multiple posting newcomer
  • *
  • Posts: 51
Yes, long time no see. LOL.
I still use cb almost every day and plan to make a project wizard in our team as a RAD tool. So, I always keep my local code as fresh as remote svn repo, and because of inconvenience of svn, I have to fork a git repo at github, and fresh it as soon as possible(if all are ok). So, found the issue.
And, I think it's not a good idea that there were some cb projects or workspaces depended on wx version line **_wx30_**, **_wx32_** in cb src directory. I home the official team would plan to improve it too.
thanks.

Offline Wkerry

  • Multiple posting newcomer
  • *
  • Posts: 50
This git repo is close to SVN as I have found:
    https://github.com/arnholm/codeblocks_sfmirror

Have a look at the following for a single CBP files that can build various wxwidget versions:
    https://github.com/gerard-durand/codeblocks_gd_cbps

Offline kipade

  • Multiple posting newcomer
  • *
  • Posts: 51
This git repo is close to SVN as I have found:
    https://github.com/arnholm/codeblocks_sfmirror
Cool! From the commit author, it seems the origin team members commit here again.
Have a look at the following for a single CBP files that can build various wxwidget versions:
    https://github.com/gerard-durand/codeblocks_gd_cbps
Only a little pitty that, Im a Linux user, the project is for windows users. And, I simply modify *_wx32_unix*s and remove version tag, it works for me, and commit as a new develop branch at: https://github.com/kipade/codeblocks
Thank you very much.

Offline Miguel Gimenez

  • Developer
  • Lives here!
  • *****
  • Posts: 1612
Fixed in r13488, thank you.