{thread search] File mask not saved

[BlueHazzard]

Hi,
does also someone else experience that the file mask of the thread search plugin is not saved on pressing ok in the options dialog?
OS: windows 7, wx31 latest trunk...
Steps to reproduce:
1) Start codeblocks
2) Enable thread search panel
3) hit the options button.
4) Set the file mask to something like *.cpp;*.h
5) Hit ok
6) Make search. --> The mask is ignored
7) Hit the options button again
The mask is reseted back to *.*

[BlueHazzard]

it seems that the file mask is ignored for project files?
So, either we disable the control on selecting workspace/project or we implement the mask on this, or am i missing something?

[Quiss]

Yes, it is ignored; it doesn't matter if you search in open files or project files. Also the mask is reset even if you don't make search; after step5, click options button again and you see it's resetted.

11455, wx311, windows10-64

[Miguel Gimenez]

The mask is saved in default.conf and loaded OK, but the loaded value is lost (either overwritten or ignored) and *.* is used instead. In addition to this the search masks ("*.*" and "*.cpp;*.c;*.h") should appear when opening the combobox but they are also lost.

[BlueHazzard]

I know that this worked in the past... A quick search in the svn log did not revealed some changes that mattered... Probably something with wx30 again...

[Miguel Gimenez]

This patch solves the *.* issue (don't know if filtering works). The combobox constructor fired a TEXT event who overwrote the searchmask value in finddata.

The empty combobox must be fixed also.

[BlueHazzard]

There is no data in the drop down boxes because the panel gets destroyed every time the dialog closes and the items are added only at the beginning once, as far as i can tell..

[BlueHazzard]

Ok, i come to the conclusion, that in the option dialog it was never implemented to have a populated drop down list.
The drop down list is only implemented in the panel in the "log&others" panel and there it works...
In the settings dialog it seems to never have worked (i remember other, but i may be wrong...)

[BlueHazzard]

Here is a patch that fixes this. But it introduces some strange UI behavior for resizing the options panel...
I probably will need some help for this...

In a scond patch i will try to add the file mask for project/workspace files...

[ollydbg]

http://forums.codeblocks.org/index.php/topic,22198.msg151287.html#msg151287

I think I have this issue reported, see the above link and discussion. I found the post by Google.

[BlueHazzard]

So there are 3(4) bugs in this plugin?
1) The crash that is original reported in your thread (fixed by updating compiler/wx version? )
2) The value in the mask text control field gets overwritten by "*.*". This happens only on windows with wx>3.0 (or at least not in wx2.. This is fixed with the patch provided by Miguel Gimenez
3) The drop down boxes in the options dialog (called from the toolbar or from settings->environment->thread search) do not get populated. This should not work on any operating system because it is not implemented as far as i can see. This should be fixed with my patch
(4) The mask is not applied on project and workspace files. I think this is a bug and i will fix this too...

Am i here correct, or do i miss something here?

[ollydbg]

So there are 3(4) bugs in this plugin?
1) The crash that is original reported in your thread (fixed by updating compiler/wx version? )

Yes, newer GCC version such as GCC 7.2 don't show this crash.

2) The value in the mask text control field gets overwritten by "*.*". This happens only on windows with wx>3.0 (or at least not in wx2.. This is fixed with the patch provided by Miguel Gimenez

I will try to apply this patch and see whether it fixed the issue. Thanks.

I don't know the (3) and (4) issue currently.

[Miguel Gimenez]

So there are 3(4) bugs in this plugin?

There is at least one more bug, a crash when disabling the plugin due to an use-after-free issue. This is described in ticket 777, and I posted there a possible patch.

https://sourceforge.net/p/codeblocks/tickets/777/

[BlueHazzard]

Any feedback on this?

If no one is against them i will commit them one by one in the next days (beside the 777, there still seems to be some discussion)

[BlueHazzard]

Here is the patch for point 4: apply mask on every search request (files, workspace, project and target)

[BlueHazzard]

Ok, i applied the patches about the file masks: points 2 and 4
There is still point 3, where i still have to figure out how the sizer have to be set and the crash reported in ticket 777

[oBFusCATed]

@bluehazzard: Are there anything else here to be fixed? I've made a lot of changes to the ThreadSearch, so I might have accidentally fixed it.

[BlueHazzard]

With the latest trunk i still see some wired behaviour:
1) Open the Thread search tab
2) press show/hide dir items
3) now if you click trough the search options (search in workspace, search in open files ecc.) The file mask is only enabled if you search in directory. I do not know it this is wanted, or if the mask should also apply for workspace search ecc.. Anyway:
4) Search in workspace, execute the search
5) Search successful, but the file mask now seems to be active (not greyed out) but you can not enter anything. It only appears enabled, but is disabled...

A other thing:
If you open the thread search options and modify the "Search in files" again, like search in workspace, search in open files ecc the mask control is never deactivated... So it is inconsistent with the tab behaviour...

[edit] windows, wxWidgets 3.1.4