Developer forums (C::B DEVELOPMENT STRICTLY!) > Development
exchndl related patch because win32/lib folder is empty in SVN
ollydbg:
--- Quote from: stahta01 on September 05, 2015, 06:35:52 pm ---
--- Quote from: scarphin on September 05, 2015, 05:37:38 pm ---Ok now it's clear. I still think introducing variables for output/intermediate folders is not a good idea because of the main update script but a separate lib folder sounds good.
--- End quote ---
I am starting work on adding the lib30 folder to the wx30 CB projects.
Next, will be adding lib30_64 folder.
Last, I will work on adding lib and lib30 to the Linux CB Projects.
All of the work will be without using new CB custom vars; since at least two devs are against that for some reason I fail to follow.
Edit: Feedback wanted a single big patch or as I think best two patches one with the CB reformatting and the second with the real change?
Tim S.
--- End quote ---
Here is my point:
1, I'm OK with the 0001.patch(also, I prefer the two patches version, a single big patch is too bad), which is a obvious patch
2, about your 0002 patch. Put all the libs in a single folder is a good idea. I see two versions: one version you use CB_BIN, CB_LIB, CB_OBJ, the other one version you just use the relative paths. I prefer the first version, because, if we use CB_XXX variable in both "codeblocks.cbp", and "codeblocks_wx30.cbp" and ""codeblocks_wx30_64.cbp", then those three cpb files looks much the same. Since in many cases, only the CB_XXX are different.
3, about the update*.bat, I think we can create a "target" in the cbp which do the job, manually run them is not quite good idea.
stahta01:
--- Quote from: ollydbg on September 06, 2015, 03:09:33 am ---
--- Quote from: stahta01 on September 05, 2015, 06:35:52 pm ---
--- Quote from: scarphin on September 05, 2015, 05:37:38 pm ---Ok now it's clear. I still think introducing variables for output/intermediate folders is not a good idea because of the main update script but a separate lib folder sounds good.
--- End quote ---
I am starting work on adding the lib30 folder to the wx30 CB projects.
Next, will be adding lib30_64 folder.
Last, I will work on adding lib and lib30 to the Linux CB Projects.
All of the work will be without using new CB custom vars; since at least two devs are against that for some reason I fail to follow.
Edit: Feedback wanted a single big patch or as I think best two patches one with the CB reformatting and the second with the real change?
Tim S.
--- End quote ---
Here is my point:
1, I'm OK with the 0001.patch(also, I prefer the two patches version, a single big patch is too bad), which is a obvious patch
2, about your 0002 patch. Put all the libs in a single folder is a good idea. I see two versions: one version you use CB_BIN, CB_LIB, CB_OBJ, the other one version you just use the relative paths. I prefer the first version, because, if we use CB_XXX variable in both "codeblocks.cbp", and "codeblocks_wx30.cbp" and ""codeblocks_wx30_64.cbp", then those three cpb files looks much the same. Since in many cases, only the CB_XXX are different.
3, about the update*.bat, I think we can create a "target" in the cbp which do the job, manually run them is not quite good idea.
--- End quote ---
I agree that CB_XXX variable version is better; but, others do NOT agree.
I plan to finish completely the patch without using CB_XXX variables.
And, I will then create a new patch for myself that uses CB_XXX variables.
I will post a link to it; and you can feel free to try to get it applied upstream.
I think just getting the lib,lib30, and lib30_64 patch(es) applied is all I feel up to making the effort to get applied to SVN.
Point 3. I think having a single manually called batch file per project group to copy files from devel* to output* is better than having a target in the CB project call batch files. Project group means like the Windows_32bit_wx28, Windows_32bit_wx30, and Windows_64bit_wx30.
Tim S.
stahta01:
Found that my add lib patches was NOT needed to remove the warning and likely not needed to remove the build error.
I needed to move "exchndl/win32/lib" before "devel" in the linker search and deleted the src target pre-build step file deletion.
And, my warning went away.
Tim S.
stahta01:
The lib folder structure in code tags below
I added folders for the static libs and removed lib name suffixes of 30, 64, or 30_64.
--- Code: ---lib
|-- base
| `-- libtxml.a
|-- libcodeblocks.a
|-- libwxchartctrl.a
|-- libwxcustombutton.a
|-- libwxflatnotebook.a
|-- libwximagepanel.a
|-- libwxkwic.a
|-- libwxled.a
|-- libwxpropgrid.a
|-- libwxsmithlib.a
|-- libwxspeedbutton.a
|-- libwxtreelist.a
|-- plugins
| |-- compilergcc
| | `-- libdepslib.a
| `-- contrib
| |-- SpellChecker
| | |-- libhunspell.a
| | `-- libwxSpellChecker.a
| |-- devpak_plugin
| | `-- libbz2.a
| |-- help_plugin
| | |-- libbzip2.a
| | `-- libz.a
| |-- source_exporter
| | `-- libwxPdfDocument.a
| `-- wxSmithPlot
| `-- libMathPlot.a
`-- sdk
|-- libsqplus.a
|-- libsqstdlib.a
|-- libsquirrel.a
`-- libwxscintilla_cb.a
10 directories, 24 files
lib30
|-- base
| `-- libtxml.a
|-- libcodeblocks.a
|-- libwxchartctrl.a
|-- libwxcustombutton.a
|-- libwxflatnotebook.a
|-- libwximagepanel.a
|-- libwxkwic.a
|-- libwxled.a
|-- libwxsmithlib.a
|-- libwxspeedbutton.a
|-- plugins
| |-- compilergcc
| | `-- libdepslib.a
| `-- contrib
| |-- SpellChecker
| | |-- libhunspell.a
| | `-- libwxSpellChecker.a
| |-- devpak_plugin
| | `-- libbz2.a
| |-- help_plugin
| | |-- libbzip2.a
| | `-- libz.a
| `-- source_exporter
| `-- libwxPdfDocument.a
`-- sdk
|-- libsqplus.a
|-- libsqstdlib.a
|-- libsquirrel.a
`-- libwxscintilla_cb.a
9 directories, 21 files
lib30_64
|-- base
| `-- libtxml.a
|-- libcodeblocks.a
|-- libwxchartctrl.a
|-- libwxcustombutton.a
|-- libwxflatnotebook.a
|-- libwximagepanel.a
|-- libwxkwic.a
|-- libwxled.a
|-- libwxsmithlib.a
|-- libwxspeedbutton.a
|-- plugins
| |-- compilergcc
| | `-- libdepslib.a
| `-- contrib
| |-- SpellChecker
| | |-- libhunspell.a
| | `-- libwxSpellChecker.a
| |-- devpak_plugin
| | `-- libbz2.a
| |-- help_plugin
| | |-- libbzip2.a
| | `-- libz.a
| `-- source_exporter
| `-- libwxPdfDocument.a
`-- sdk
|-- libsqplus.a
|-- libsqstdlib.a
|-- libsquirrel.a
`-- libwxscintilla_cb.a
9 directories, 21 files
--- End code ---
stahta01:
Updated patches; I am still testing these patches.
My windows 64 bit computer over heated last night; so, I really need to at least test 64 bit version.
And, I plan to do a full rebuild of all three groups of patches.
(three groups: Windows 32bit wx2.8, Windows 32bit wx3.0, Windows 64bit wx3.0)
Tim S.
Navigation
[0] Message Index
[#] Next page
[*] Previous page
Go to full version