Developer forums (C::B DEVELOPMENT STRICTLY!) > Plugins development
Class Wizard Plugin Enhancements
scarphin:
--- Quote from: oBFusCATed on October 09, 2014, 01:15:24 am ---Sorry to be the git advocate once more time, but if you plan to do multiple patches git is one of the softwares you can use.
--- End quote ---
Thnx for the help. My problem is not creating patches, I can do that just fine (only with svn as of yet). What I was trying to ask was something different. Let me be more specific. Consider the scenario: I modified the file 'a.cpp' to implement some feature. I created a patch and submitted it. While waiting for the patch to be approved I decided to implement another feature again by modifying the file 'a.cpp'. Now should I modify the original 'a.cpp' lacking the previous feature OR modify the already modified 'a.cpp'? If both feature modifications overlap the same part of the code, I think the former case will be impossible. And for the latter case, first feature must be approved for the second patch to work. Or is there a better approach to manage this situation?
--- Quote from: oBFusCATed on October 09, 2014, 01:15:24 am ---About the tabs - just consider the settings for the editors and don't add UI for choosing tabs vs spaces... It should just work automagically...
--- End quote ---
Please elaborate. I didn't quite get what you mean. If you mean the class wizard should show the same exact behavior (spaces as default etc...), my intention is to keep it like that as I mentioned in my first post. What I have in mind is to insert a checkbox titled 'use tabs for indentation' which will be unchecked by default and when it is checked indentation spaces will turn into tabs automagically. ;)
oBFusCATed:
--- Quote from: scarphin on October 09, 2014, 02:52:29 am ---Thnx for the help. My problem is not creating patches, I can do that just fine (only with svn as of yet). What I was trying to ask was something different. Let me be more specific. Consider the scenario: I modified the file 'a.cpp' to implement some feature. I created a patch and submitted it. While waiting for the patch to be approved I decided to implement another feature again by modifying the file 'a.cpp'. Now should I modify the original 'a.cpp' lacking the previous feature OR modify the already modified 'a.cpp'? If both feature modifications overlap the same part of the code, I think the former case will be impossible. And for the latter case, first feature must be approved for the second patch to work. Or is there a better approach to manage this situation?
--- End quote ---
With git you can do both of these: you can commit every change as a separate commit on top of the older changes or you can create separate branches for different changes. It is up to you.
--- Quote from: scarphin on October 09, 2014, 02:52:29 am ---Please elaborate. I didn't quite get what you mean. If you mean the class wizard should show the same exact behavior (spaces as default etc...), my intention is to keep it like that as I mentioned in my first post. What I have in mind is to insert a checkbox titled 'use tabs for indentation' which will be unchecked by default and when it is checked indentation spaces will turn into tabs automagically. ;)
--- End quote ---
The thing is that the editor knows if it has to use tabs or spaces (and how many).
So there should be no need to add an explicit option in the dialog.
There are the cbEditor::DoIndent and DoUnindent methods also which might be useful.
.
scarphin:
--- Quote from: oBFusCATed on October 09, 2014, 09:26:58 am ---The thing is that the editor knows if it has to use tabs or spaces (and how many).
So there should be no need to add an explicit option in the dialog.
--- End quote ---
If you mean editor settings, it is very unwise to let them decide. As a simple example, I have tabs chosen for every setting in the editor and if I had to create a class for CB, it would insert tabs everywhere. Or is it something else?
scarphin:
Patch for item 1 is ready. Yet I couldn't find any patch tracker on sourceforge but only tickets as mentioned on the frontpage of cb's website. Shall I submit my patch there as attachment or am I missing something? Please advise!
Bat:
Yes, same question for me on another topic.
Should theses patchs commited on a perso github account, where we de a clone of C::B git ?
Navigation
[0] Message Index
[#] Next page
[*] Previous page
Go to full version