Developer forums (C::B DEVELOPMENT STRICTLY!) > Plugins development
Class Wizard Plugin Enhancements
oBFusCATed:
Either put them as attachments in sf.net tickets or as pull requests with a topic on the forum.
Keep in mind that some of the developers don't use or like git so you're lowering the chances for inclusion.
@Morten: Can we have a separate status/category in the issue tracker on sf for patches?
--- Quote from: scarphin on October 09, 2014, 12:27:59 pm ---If you mean editor settings, it is very unwise to let them decide. As a simple example, I have tabs chosen for every setting in the editor and if I had to create a class for CB, it would insert tabs everywhere. Or is it something else?
--- End quote ---
Why would it be unwise? The user has decided that he wants tabs and the class wizard generate tabs for indents. If he/she wants to use spaces (2,3,4 or 7) the class wizard must use spaces for the indentations.
p.s. the preview post feature of the forum seems broken :(
scarphin:
I submitted the patch for itme 1 (member variable scope implementation) to sourceforge with the ticket link -> http://sourceforge.net/p/codeblocks/tickets/61/
Some comments about the patch:
1- I couldn't find a way to edit the .xrc file visually so I had to edit it by hand. I couldn't get anything even wxsmith to load the file (it complained something about 'project is not configured for wxsmith' or something). So please feel free to perform any bug fixes or optimizations I might have missed.
2- Scope dropdown defaults to 'private' as in the original class wizard.
3- Member variable list window is quite narrow to fit anything that is even not reasonably long so I abbreviated the scope delimiters as 'pub, pro, pri'. A list window with a horizontal slider may do better or some other notation.
4- I added some extra empty lines to make the generated code easier to read. I think the generated code is quite messy when the documentation is enabled. 'bool addnewline' variable is used to prevent extra empty lines to be inserted in case there are no public variables and/or getter, setter methods.
--- Quote from: oBFusCATed on October 09, 2014, 08:46:47 pm ---Why would it be unwise?
--- End quote ---
--- Quote from: scarphin on October 09, 2014, 12:27:59 pm ---If you mean editor settings, it is very unwise to let them decide. As a simple example, I have tabs chosen for every setting in the editor and if I had to create a class for CB, it would insert tabs everywhere.
--- End quote ---
--- Quote from: oBFusCATed on October 09, 2014, 08:46:47 pm ---The user has decided that he wants tabs and the class wizard generate tabs for indents. If he/she wants to use spaces (2,3,4 or 7) the class wizard must use spaces for the indentations.
--- End quote ---
As I already mentioned that will be presented as an option in the wizard and if you mean it should default to what the user has set in his/her editor settings, I will implement that too.
oBFusCATed:
I don't think there is a need for an option.
Why would you bother to spend time on add UI, additional code to handle the special case, add additional complexity to the UI increase the maintenance cost?
99.999% of the people will be happy with the default behaviour, so I don't see why bother with the options.
Also we're not living in the 90's or early 2000's where everything should be configurable:)
scarphin:
--- Quote from: oBFusCATed on October 10, 2014, 07:58:18 pm ---I don't think there is a need for an option.
Why would you bother to spend time on add UI, additional code to handle the special case, add additional complexity to the UI increase the maintenance cost?
--- End quote ---
I have nothing else to say then. You're the boss, I respect your decision. I didn't mean to add extra maintenance overcome for an option no developer opts for, sorry for that. I don't use documentation much and fortunately it doesn't affect the code so I don't see a reason to add an option for that too which will increase complexity.
scarphin:
I see that my patch was applied in trunk but my first version lacked the spacing under the scope elements. I attached a simple patch to add some spacing between the scope elements and 'add getter method' tickbox in case someone may want to review. Also the initial value of 'remove prefix' box seems to be broken, it should be 'm_' but it is 'm&'. Attached patch also fixes that.
Navigation
[0] Message Index
[#] Next page
[*] Previous page
Go to full version