[feature request]Display a read-only icon next to filename in the tab

[teto]

Hi,

I am not sure if it is "waf" (fork of Scons https://code.google.com/p/waf/wiki/FAQ) specific but it copies all headers from all files in a read-only directory. So often codeblocks will open such a file (on "Find declaration" for instance). So I have two identical headers open and often I find myself typing in a read only file.

This would be nice if in the tab of a read-only file, there were the same read-only icon as in te "Open files" window next to the filename.
This may look as a specific usecase (may also occurs when you work on libc or kernel sources, coeblocks open readonyl header instead of the one of the current project maybe ?) so I would understand if that would get turned down.

Cheers

[oBFusCATed]

It might be a usefull feature, but I'm not sure if it will be possible because of limitations in the api of wxaui notebook.

[teto]

This does not need to be an icon, it could be a character (like the "*" prepended when a file has been modified) or the font (bold to show readonly).

[oBFusCATed]

The API supports icons, so it will be an icon... will try to do it in the next couple of days...

[SteelRat]

Found by google pics:

Is this implemented on Mac OS only?
From documentation:

Code

virtual bool wxAuiNotebook::SetPageImage(size_t n, int imageId)	
Sets the image index for the given page.

image is an index into the image list which was set with SetImageList().

>>> Since 2.9.3

[Jenna]

As you can see in the "Logs and others" it's supported on all platforms (at least all we support with C::B).

@oBFusCATed:
I already started to work on it.
The problem is to find a point to implement it, where it works all the time (if changed from inside C::B and from outside C::B).

[teto]

Great news ! Thanks for taking my proposition into consideration.

[oBFusCATed]

The problem is to find a point to implement it, where it works all the time (if changed from inside C::B and from outside C::B).

I'm not so sure we need to make this as robust as you've described.
Can't you use the code for detecting if an opened file has changed to detect if the read-only attribute has been changed, too?

[Jenna]

I attach two patches and a png-file for test.
Both need to be applied and the png has to be copied into src/src/resources/images/

[MortenMacFly]

I attach two patches and a png-file for test.

Within your patch: Probably you are missing that an editor case have an read-only state, too -> ed->IsReadOnly(). This should be pout into the computation of the readOnly var...

[Jenna]

I attach two patches and a png-file for test.

Within your patch: Probably you are missing that an editor case have an read-only state, too -> ed->IsReadOnly(). This should be pout into the computation of the readOnly var...

You are right.
Patch attached.

I think we should also add a(n empty) SetReadOnly-function to editorbase-class.
What do you think ?

[MortenMacFly]

Yes, that's a good idea.I've already patched my version of c::B because handling read only visibility is broken in many ways...

[danselmi]

@jens: Any plans to apply in trunk? I'am using it since over a month without problems.

[MortenMacFly]

@jens: Any plans to apply in trunk? I'am using it since over a month without problems.

I can confirm it works on Windows.

[Jenna]

I just committed ths and some other changes (mainly save pane-layout stuff) to sf (svn r9940 - 9949) in the hope it does not break anything.
Please test and report any issues (or fix them if you are a dev).

[teto]

It works perfectly with the latest nightly and I can totally live with that. I just wanted to point out a possible improvement cf enclosed picture, there is one additionnal place where the read only icon could appear (ie, in the tab list).
 

[oBFusCATed]

I doubt there is api for putting icons in there.