Author Topic: Ruby lexer seems broken  (Read 8273 times)

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 13406
    • Travis build status
Ruby lexer seems broken
« on: February 01, 2014, 04:43:33 pm »
I've just saw that the lexer for Ruby is broken.
Does someone know why?
It works as expected in Scite 3.3.6.
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline dmoore

  • Developer
  • Lives here!
  • *****
  • Posts: 1576
Re: Ruby lexer seems broken
« Reply #1 on: February 01, 2014, 06:12:34 pm »
I don't really know ruby, but it looks OK to me on this sample: http://sandbox.mc.edu/~bennet/ruby/code/box_rb.html.
Is the highlight mode correctly set for ruby?

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 13406
    • Travis build status
Re: Ruby lexer seems broken
« Reply #2 on: February 01, 2014, 06:28:56 pm »
This is how it looks on my machine: http://cmpt.benbmp.org/codeblocks/screens/ruby_lexer.png rev 9615 build from my git repo.
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline dmoore

  • Developer
  • Lives here!
  • *****
  • Posts: 1576
Re: Ruby lexer seems broken
« Reply #3 on: February 01, 2014, 07:04:41 pm »
Oh, missing keywords? (That appears to be the case on mine too)

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 13406
    • Travis build status
Re: Ruby lexer seems broken
« Reply #4 on: February 01, 2014, 09:15:51 pm »
I think there are more problems, because the class/module/function name is no highlighted with the proper colour. They could be specified separately.
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline Jenna

  • Administrator
  • Lives here!
  • *****
  • Posts: 7252
Re: Ruby lexer seems broken
« Reply #5 on: February 01, 2014, 09:39:05 pm »
I don't know much about (scintilla's) lexers, vut there seem to be no keywords defined at all.

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 13406
    • Travis build status
Re: Ruby lexer seems broken
« Reply #6 on: February 01, 2014, 11:17:39 pm »
Yeah, adding the keywords at slot 0 fixed the problem.
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline MortenMacFly

  • Administrator
  • Lives here!
  • *****
  • Posts: 9723
Re: Ruby lexer seems broken
« Reply #7 on: February 02, 2014, 09:01:27 pm »
I should check the changelog of Scintilla. But indeed, I am testing scintilla and editors itself but not for all lexers. :-/

BTW: There is another patch to (wx)Scintilla pending...

Edit: Here is the main part of the scintilla the changelog - there were a lot changes on lexers...
Quote
Version 3.3.8 improves drawing quality and enhances lexers.
Version 3.3.7 uses responsive scrolling on OS X 10.9, enhances lexers, and fixes bugs.
« Last Edit: February 02, 2014, 09:03:13 pm by MortenMacFly »
Compiler logging: Settings->Compiler & Debugger->tab "Other"->Compiler logging="Full command line"
C::B Manual: https://www.codeblocks.org/docs/main_codeblocks_en.html
C::B FAQ: https://wiki.codeblocks.org/index.php?title=FAQ