Developer forums (C::B DEVELOPMENT STRICTLY!) > Development

wx2.8.12, sending event cross threads are not safe in current CB source

<< < (4/5) > >>

golgepapaz:
I still thinkthat the event does not need its own header and implementation file.sdk_events will do fine. That profiling
stuff is still not optional and please don't forget to update the other project configurations . (If you are commited to
going with a separate file please also add header file to the projects for the sake of convention.)

ollydbg:

--- Quote from: golgepapaz on July 22, 2013, 06:50:02 pm ---I still thinkthat the event does not need its own header and implementation file.sdk_events will do fine.

--- End quote ---
OK, I agree with you, and I will change the code.


--- Quote ---That profiling
stuff is still not optional and please don't forget to update the other project configurations . (If you are commited to
going with a separate file please also add header file to the projects for the sake of convention.)

--- End quote ---
OK, I will add the preprocessor directive, and do my best, note I only have a windows and wx2.8.12, so adding to other project files may cause some build issue. :)

ollydbg:
OK, this is the new patches, by using the "git rebase -i" tool, I can nicely split one commit to two. (Git is wonderful, see how to split a commit here: version control - How to split last commit into two in Git - Stack Overflow)

The first patch introduce the performance hook measurement, it use preprocessor directive now, see first attachment.
The second patch introduce the CodeBlocksThreadEvent class, and use it.

BTW: The patch is generate by GIT command like:

--- Code: ---$ git format-patch -M -C --output-directory /f/cb_sf_git/patches master...90654
dbd50701149639
--- End code ---

MortenMacFly:

--- Quote from: ollydbg on July 23, 2013, 08:26:37 am ---OK, this is the new patches, by using the "git rebase -i" tool, I can nicely split one commit to two. (Git is wonderful [...]

--- End quote ---
...except that both patches (as expected) do not apply to our SVN source tree. >:(

ollydbg:

--- Quote from: MortenMacFly on July 24, 2013, 07:44:39 am ---
--- Quote from: ollydbg on July 23, 2013, 08:26:37 am ---OK, this is the new patches, by using the "git rebase -i" tool, I can nicely split one commit to two. (Git is wonderful [...]

--- End quote ---
...except that both patches (as expected) do not apply to our SVN source tree. >:(

--- End quote ---
OK, I will create the svn patches soon.

Question: How do you apply patches, for the git style patch, you can just run the command in your svn local copy.

patch <./xxx.patch

Note, I'm using the patch utility from MSYS.

EDIT: I'm not sure how to create two continuous patches in SVN, for example, 001.patch, 002.patch, but 002.patch can only applied after 001.patch.

Navigation

[0] Message Index

[#] Next page

[*] Previous page