Developer forums (C::B DEVELOPMENT STRICTLY!) > Development
wx2.8.12, sending event cross threads are not safe in current CB source
danselmi:
--- Quote from: MortenMacFly on June 25, 2013, 09:54:12 pm ---This is (however) most likely a design issue in the SpellChecker plugin.
--- End quote ---
Corrected in rev. 9164
danselmi:
--- Quote from: oBFusCATed on June 26, 2013, 12:15:11 am ---Is OccurrenceHighlighter still needed? I don't see in the contrib subdir...
--- End quote ---
OccurrenceHighlighter is an addition to the occurrence highlighting implemented in the core. It is able to permanently (until the string gets removed from the list again) highlight strings in all editors. Not only the currently selected.
Should I add it into contrib subdir?
MortenMacFly:
--- Quote from: danselmi on June 26, 2013, 12:58:52 am ---Should I add it into contrib subdir?
--- End quote ---
I think so, yes (in fact I was under the assumption its there already...). I find it quite useful!
And thanks for the fix, btw...
oBFusCATed:
--- Quote from: danselmi on June 26, 2013, 12:58:52 am ---Should I add it into contrib subdir?
--- End quote ---
I'd say core and also extract the other highlight occurrence code from the sdk in it.
ollydbg:
--- Quote from: ollydbg on June 21, 2013, 05:34:54 pm ---Note my patch is only a draft patch, which show the direction, but it surely need all your comments. So, thanks for all your comments.
@golgepapaz
I think a good place to put the new event in sdk_events.h and sdk_events.cpp. But for me, I just put it in a new file, because once I change the sdk_events.h, then I need to rebuild all my targets..... That's some times waste a lot of time.
I believe that sending event cross thread not only happens in CC.
--- End quote ---
Now, I add the class implementation in a cpp file.
This is a new patch ( I add a new cpp file in the SDK)
See attachment, any comments?
Navigation
[0] Message Index
[#] Next page
[*] Previous page
Go to full version