Developer forums (C::B DEVELOPMENT STRICTLY!) > Development
Some UI refactoring/tidy up
dmoore:
--- Quote from: MortenMacFly on August 30, 2012, 08:11:06 am ---Well, when compiling the C::B sources with the patch applied, compilation of the plugins (namely codesnippets) will fail:
C:/Devel/CodeBlocks/src/plugins/contrib/codesnippets/editor/seditormanager.cpp:1524:101: error: cannot allocate an object of abstract type 'FindDlg'
C:/Devel/CodeBlocks/src/plugins/contrib/codesnippets/editor/seditormanager.cpp:1527:104: error: cannot allocate an object of abstract type 'ReplaceDlg'
Can you provide a complete patch, so one can compile the whole workspace?
--- End quote ---
ugh... had no idea codesnippets did this (I will remember to build the whole workspace next time). So I have to copy a lot of my fixes across to CodeSnippets because it reimplements a lot of C::Bs editor functionality (SEditorManager)? I notice the code has been changed a little bit (e.g. no find in files, though I note that the find in files still appears in the find dialog)
IMHO codesnippets would be more consistent if the plugin version allowed you to edit snippets in the regular editor notebook. Also, this may just a problem with my default.conf, but snippets does not work properly for me. I add a few snippets using the default name of new snippet but different content. Then when I click them they all have the name "codesnippets.txt" in the editor and the same content.
Here's a separate patch for CodeSnippets that as a first pass that does the minimal fix to use the new combined dialog, I haven't done more because I am not sure how it is supposed to work. Should it have find/replace in files functionality? Then the scope options in the regular C::B shouldn't really apply (e.g. why would I search in project/workspace for snippet??). Perhaps this plugin should really have its own dialogs?
MortenMacFly:
--- Quote from: dmoore on August 30, 2012, 03:10:24 pm ---Perhaps this plugin should really have its own dialogs?
--- End quote ---
IMHO it is because besides the plugin, the codesnippets project also includes a standalone app to edito your snippets. For this to work, the dialogs were "copied" and renamed. Not nice, I know...
dmoore:
--- Quote from: MortenMacFly on August 30, 2012, 06:23:00 pm ---
--- Quote from: dmoore on August 30, 2012, 03:10:24 pm ---Perhaps this plugin should really have its own dialogs?
--- End quote ---
IMHO it is because besides the plugin, the codesnippets project also includes a standalone app to edito your snippets. For this to work, the dialogs were "copied" and renamed. Not nice, I know...
--- End quote ---
Actually I think the dialogs aren't copied, just imported by linking the app with libcodeblocks. Would be better if they were copied.
Anyway, I can do more fixes to CodeSnippets later. For now, just let me know what you think of the new functionality, and whether you think additional tweaks to the layout of the dialogs are needed. (e.g. does the spacing around the find and replace dialogs bother you? An option would be to put the extra space, which is needed for multiline mode to avoid resizing the entire dialog when switching modes, at the bottom when not in that mode)
Alpha:
Is there any chance Thread search might be merged into the standard search (only really makes sense for Find in files)? I find it a little confusing to have the duplicate search buttons, but I like features of both. (Just a thought.)
dmoore:
--- Quote from: Alpha on August 31, 2012, 12:03:45 am ---Is there any chance Thread search might be merged into the standard search (only really makes sense for Find in files)? I find it a little confusing to have the duplicate search buttons, but I like features of both. (Just a thought.)
--- End quote ---
Yes, I have give some thought to making the search use a worker thread (for find). Are there other features besides that?
Navigation
[0] Message Index
[#] Next page
[*] Previous page
Go to full version