Developer forums (C::B DEVELOPMENT STRICTLY!) > Development
Some UI refactoring/tidy up
MortenMacFly:
--- Quote from: dmoore on August 29, 2012, 07:16:37 am ---So OK I was wrong, but isn't that partly an issue with svn diff? Why does it treat the added file as if it was in revision 8239, when clearly it wasn't? I used svn cp, but I guess diff just treats the cp as having occurred and just reports the changes.
--- End quote ---
Maybe... I wonder how "svn cp" and "svn add" are interpreted by patch. I mean: In both cases you have a brand new file. From a "diff"-view perspective its the same. But: If you look at both patches, in one case you get a diff to an existing file, in the other you get the full file. I guess its just a mystery...
dmoore:
There is some unconvincing rationalization of the issue here. They mention a "treat copies as adds" option, but if default behavior produces broken patches I would call that a bug.
Anyway, any thoughts on the patch? (Note that the patch does not remove the files that are no longer needed)
MortenMacFly:
--- Quote from: dmoore on August 29, 2012, 04:00:38 pm ---Anyway, any thoughts on the patch? (Note that the patch does not remove the files that are no longer needed)
--- End quote ---
Hey, I've just managed to compile C::B... please gimme more than 5 minutes to try... ;D
BTW: Which files should I remove now? (Header, source, resource files?!)
dmoore:
Sorry ... :D
--- Quote from: MortenMacFly on August 29, 2012, 05:58:48 pm ---BTW: Which files should I remove now? (Header, source, resource files?!)
--- End quote ---
It will run as is, but eventually will need to remove find_dialog.xrc, finddialog.cpp, finddlg.h, finddlg.cpp, replacedlg.cpp, replacedlg.h (in retrospect a smarter way to create the patch would be to svn mv replacedlg to findreplacedlg)
Could also rename replace_dialog.xrc find_replace_dialog.xrc
Will then need to adjust project/make files accordingly
MortenMacFly:
--- Quote from: dmoore on August 29, 2012, 06:11:11 pm ---Will then need to adjust project/make files accordingly
--- End quote ---
Well, when compiling the C::B sources with the patch applied, compilation of the plugins (namely codesnippets) will fail:
C:/Devel/CodeBlocks/src/plugins/contrib/codesnippets/editor/seditormanager.cpp:1524:101: error: cannot allocate an object of abstract type 'FindDlg'
C:/Devel/CodeBlocks/src/plugins/contrib/codesnippets/editor/seditormanager.cpp:1527:104: error: cannot allocate an object of abstract type 'ReplaceDlg'
Can you provide a complete patch, so one can compile the whole workspace?
Navigation
[0] Message Index
[#] Next page
[*] Previous page
Go to full version