Well, when compiling the C::B sources with the patch applied, compilation of the plugins (namely codesnippets) will fail:
C:/Devel/CodeBlocks/src/plugins/contrib/codesnippets/editor/seditormanager.cpp:1524:101: error: cannot allocate an object of abstract type 'FindDlg'
C:/Devel/CodeBlocks/src/plugins/contrib/codesnippets/editor/seditormanager.cpp:1527:104: error: cannot allocate an object of abstract type 'ReplaceDlg'
Can you provide a complete patch, so one can compile the whole workspace?
ugh... had no idea codesnippets did this (I will remember to build the whole workspace next time). So I have to copy a lot of my fixes across to CodeSnippets because it reimplements a lot of C::Bs editor functionality (SEditorManager)? I notice the code has been changed a little bit (e.g. no find in files, though I note that the find in files still appears in the find dialog)
IMHO codesnippets would be more consistent if the plugin version allowed you to edit snippets in the regular editor notebook. Also, this may just a problem with my default.conf, but snippets does not work properly for me. I add a few snippets using the default name of new snippet but different content. Then when I click them they all have the name "codesnippets.txt" in the editor and the same content.
Here's a separate patch for CodeSnippets that as a first pass that does the minimal fix to use the new combined dialog, I haven't done more because I am not sure how it is supposed to work. Should it have find/replace in files functionality? Then the scope options in the regular C::B shouldn't really apply (e.g. why would I search in project/workspace for snippet??). Perhaps this plugin should really have its own dialogs?