Author Topic: doxyblocks issue  (Read 4995 times)

Offline killerbot

  • Administrator
  • Lives here!
  • *****
  • Posts: 5529
doxyblocks issue
« on: August 09, 2011, 08:36:36 am »
Can anyone try to see if they have a similar issue as I have [I am running OpenSuse 11.4 64-bit, latest svn CB].

When I issue "extract documentation" a few things should occur :
- doxygen directory created
- in there doxyfile created
- and more ...

For me step 1 is done, but not correctly causing step 2 to fail. The doxygen directory is created with the following (wrong) rights :
owner : rw
group : r
other : r

However when I look at other directories : owner + group + other have "x" right. When I add this right manually after the first failure, then the second attempt works [since the dir exists(with correct rights) it is not recreated, and step 2 works].

Looking at the code :
Code
    wxFileName fnOutput(sDoxygenDir, wxT(""));
    wxFileName fnDoxyfile(sDoxygenDir + wxFileName::GetPathSeparator() + sCfgBaseFile);
    wxFileName fnDoxygenLog(sDoxygenDir + wxFileName::GetPathSeparator() + sLogFile);
    fnOutput.Normalize();
    fnDoxyfile.Normalize();
    fnDoxygenLog.Normalize();

    if (!fnOutput.Mkdir(wxS_DEFAULT, wxPATH_MKDIR_FULL)){
        wxString sMsg = _("Failed. ") + fnOutput.GetFullPath() + _(" was not created.");
        AppendToLog(sMsg, LOG_WARNING);
        wxSetWorkingDirectory(sOldPath);
        return -1;
    }
There's very little that looks wrong : fnOutput.Mkdir(wxS_DEFAULT, wxPATH_MKDIR_FULL) .
Maybe the wxS_DEFAULT ? or a bug in wxwidgets 2.8.11 ?

Offline Jenna

  • Administrator
  • Lives here!
  • *****
  • Posts: 7252
Re: doxyblocks issue
« Reply #1 on: August 09, 2011, 09:56:34 am »
Confirmed with wxWidgets 2.8.10 .

Offline Jenna

  • Administrator
  • Lives here!
  • *****
  • Posts: 7252
Re: doxyblocks issue
« Reply #2 on: August 09, 2011, 10:14:42 am »
There's very little that looks wrong : fnOutput.Mkdir(wxS_DEFAULT, wxPATH_MKDIR_FULL) .
Maybe the wxS_DEFAULT ? or a bug in wxwidgets 2.8.11 ?
wxS_DEFAULT is wrong, because it does not include the executable-bits, instead we should use 0777 (note the leading zero), so all bits, that er not explicitely removed by the umask are set.
Can you please test if it works for you also ?

Offline killerbot

  • Administrator
  • Lives here!
  • *****
  • Posts: 5529
Re: doxyblocks issue
« Reply #3 on: August 09, 2011, 01:26:14 pm »
yes, committed the fix.

Door open for the next issue . I don't get any warnings about undoc-ed stuff anymore, though the configuration for it is in place ...