Author Topic: debuggergdb command history combo refinement  (Read 4660 times)

Offline codeman

  • Multiple posting newcomer
  • *
  • Posts: 15
debuggergdb command history combo refinement
« on: May 13, 2011, 03:11:02 pm »
Another gdb patch I submitted a few days ago:
https://developer.berlios.de/patch/?func=detailpatch&patch_id=3154&group_id=5358

At the moment when you type a command into the debugger combo box, it inserts it in the history at the beginning, so you have to press DOWN to access the last command to repeat it. This is annoying and the opposite to what you expect from other command consoles like Bash or Quake.

I changed it so that the last gdb command is appended to the end of the combo list, so you can press UP to repeat the most recent one. Nice and intuitive.

Also, commands in the list are unique, so if the entered command was already in the history it is moved down to the bottom to become the most recent again.

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 13406
    • Travis build status
Re: debuggergdb command history combo refinement
« Reply #1 on: May 13, 2011, 04:37:11 pm »
Ah, thanks... this was annoying for me, too...

p.s. if you make other debugger patches in the future, please do so against the debugger's branch, because there are many improvements and changes. (I'll port your patch to the branch)
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 13406
    • Travis build status
Re: debuggergdb command history combo refinement
« Reply #2 on: May 14, 2011, 03:21:08 am »
In svn, thank you
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline killerbot

  • Administrator
  • Lives here!
  • *****
  • Posts: 5529
Re: debuggergdb command history combo refinement
« Reply #3 on: May 14, 2011, 09:09:00 am »
can this patch also be applied to trunk ?
Then we have a debugger improvement there also ;-)

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 13406
    • Travis build status
Re: debuggergdb command history combo refinement
« Reply #4 on: May 14, 2011, 11:58:55 am »
Morten or Jens should decide, because they do the merging.
And applying the patch would probably make them suffer...
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]