Developer forums (C::B DEVELOPMENT STRICTLY!) > Development

Projectlayoutloader improvement and changes to editor zooming (patch to test)

<< < (2/3) > >>

Jenna:

--- Quote from: jens on January 12, 2011, 10:05:33 pm ---
--- Quote from: MortenMacFly on January 12, 2011, 04:30:01 pm ---
--- Quote from: jens on January 12, 2011, 12:38:44 pm ---Done in the attached patch.

--- End quote ---
This patch conflicts with the other of yours on (minimise space) my system. For the sake of easier testing (and if it doesn't cause too much overhead) is it possible that you generate a combined patch?

--- End quote ---
I can do this (it needs some manual applied changes, because both patches touch cbAuiNotebook), and I will do.
The combined patch will aso have some more nullpointer checks in cbAuiNotebbok  :wink: .

Comes (most likely) this evening.

--- End quote ---

Combines the patch attached here (http://forums.codeblocks.org/index.php/topic,13826.msg94108.html#msg94108) and the one from above (http://forums.codeblocks.org/index.php/topic,14027.msg94324.html#msg94324) plus some more nullpointer checks to (hopefully) get rid of some crashes occured on windows.

It's against trunk and will (most likely) not apply on debugger-branch, but should work for wxSmith-addons-branch.

EDIT:
Updated patch: http://forums.codeblocks.org/index.php/topic,14027.msg94568.html#msg94568

Jenna:
Updated patch against current trunk , should also apply in debugger-branch.

Do you experience any issues so far ?

Can/should it be applied to trunk ?

EDIT:

Patch updated: http://forums.codeblocks.org/index.php/topic,13826.msg94704.html#msg94704

oBFusCATed:
Jens, I'm lost in your changes...
please commit them...

The scrolling of tabs with the mouse was working last time I've checked (it was the opposite direction, but it was working (I prefer the same as FF)).
The closing problem was fixed, it was working OK.

If there are problems you can fix them in svn :)

p.s. I stopped testing when the two patches where merged...

Jenna:

--- Quote from: oBFusCATed on January 20, 2011, 12:56:39 pm ---Jens, I'm lost in your changes...

--- End quote ---

So I am  :?

What I want to know, if there are basic objections from other devs, because the patch(es) change the sdk and the behaviour of (some small parts) of C::B.

MortenMacFly:

--- Quote from: jens on January 20, 2011, 02:58:17 pm ---What I want to know, if there are basic objections from other devs, because the patch(es) change the sdk and the behaviour of (some small parts) of C::B.

--- End quote ---
From my point of view - having tested the previous (so not the one you are referring to here) combined patch - it works very well, also all crashed I had experienced are gone now.

I'd vote for (if possible) apply both changes in trunk, but having two commits... (as I said: if possible).

Navigation

[0] Message Index

[#] Next page

[*] Previous page