Developer forums (C::B DEVELOPMENT STRICTLY!) > Development

Projectlayoutloader improvement and changes to editor zooming (patch to test)

(1/3) > >>

Jenna:
This thread shows me that editor-zooming does not work consistently.

The current implementation saves the last seen zoom-factor and uses it for all newly opened editors, except for the second control in split-view.
Editors that have been opened are not zoomed automatically.

In my opinion, zooming should either only affect the editor, that has the focus, or all editors (egally whether they are opened or not).

I attach a a patch, that does exact this (configurable via "Settings -> Editor... -> Other options -> Zooming resizes all editors").
Additionally it saves the zoom-factor and the split-state on a per editor base in the project layout file.

The patch is against trunk and conflicts with my mousewheel/double-click/etc-patch (http://forums.codeblocks.org/index.php/topic,13826.msg94108.html#msg94108).

As always tester and comments/improvements/whishes ... are welcome.

Tested on debian 64-bit and winXP.

EDIT:
updated patch: http://forums.codeblocks.org/index.php/topic,14027.msg94324.html#msg94324

UberNewb:

--- Quote from: jens ---As always tester and comments/improvements/whishes ... are welcome.

--- End quote ---
May I suggest that when the user changes their font size in the menu, that it resets the zoom level of all the editors to zero? Not resetting the zoom level upon menu font size changes led to quite a bit of confusion on my part because at one point I had zoomed in the editor and this led to split editors opening up in a different font size than I thought was actually set in the menu.

Jenna:

--- Quote from: UberNewb on January 12, 2011, 11:12:56 am ---
--- Quote from: jens ---As always tester and comments/improvements/whishes ... are welcome.

--- End quote ---
May I suggest that when the user changes their font size in the menu, that it resets the zoom level of all the editors to zero? Not resetting the zoom level upon menu font size changes led to quite a bit of confusion on my part because at one point I had zoomed in the editor and this led to split editors opening up in a different font size than I thought was actually set in the menu.

--- End quote ---

Done in the attached patch.
It's configurable via checkbox below the sample text in editor config-dialog.

MortenMacFly:

--- Quote from: jens on January 12, 2011, 12:38:44 pm ---Done in the attached patch.

--- End quote ---
This patch conflicts with the other of yours on (minimise space) my system. For the sake of easier testing (and if it doesn't cause too much overhead) is it possible that you generate a combined patch?

Jenna:

--- Quote from: MortenMacFly on January 12, 2011, 04:30:01 pm ---
--- Quote from: jens on January 12, 2011, 12:38:44 pm ---Done in the attached patch.

--- End quote ---
This patch conflicts with the other of yours on (minimise space) my system. For the sake of easier testing (and if it doesn't cause too much overhead) is it possible that you generate a combined patch?

--- End quote ---
I can do this (it needs some manual applied changes, because both patches touch cbAuiNotebook), and I will do.
The combined patch will aso have some more nullpointer checks in cbAuiNotebbok  :wink: .

Comes (most likely) this evening.

Navigation

[0] Message Index

[#] Next page