Developer forums (C::B DEVELOPMENT STRICTLY!) > Development
Request : C::B View::notebook enhancements
Jenna:
--- Quote from: MortenMacFly on January 22, 2011, 02:37:35 pm ---
--- Quote from: jens on January 22, 2011, 07:51:07 am ---That's a show stopper for me.
[...]
I will not commit, before the cause is found.
--- End quote ---
Agreed.
--- End quote ---
Here comes a patch that (hopefully) fixes the issue (it does it at least on win7).
It contains some more changes (tab tooltips can now be disabled generally in "Sedttings -> View -> Notebook appearance", the dwell time can also be configured).
EDIT:
The patch will not apply to trunk later than r6931, some of the included changes are now committed.
More will follow.
I will update the patch tomorrow (it's a lot of work to split the patches :( ).
MortenMacFly:
--- Quote from: jens on January 24, 2011, 02:22:22 pm ---Here comes a patch that (hopefully) fixes the issue (it does it at least on win7).
--- End quote ---
So you were able to reproduce? I am very curious what has caused this effect! (I've no access to C::B atm...).
Jenna:
The cause was, that I always tried to restore the previous focus (windows hack), but if the previous focus was on an editor (or more precisely on a cbStyledtextCtrl), this fails after deleting the editor (of course).
Now when deleting (or removing) a page, I check whether the stored pointer (or one of its parents) is the page to be deleted (or removed). In this case I reset the stored pointer to nullptr.
The crash only happened, if the closed page was not the last page, because in this case the selection also has changed and a changed selection (via mousewheel for example) overrides has precedence over restoring the focus.
Jenna:
--- Quote from: Pecan on January 21, 2011, 04:45:33 pm ---For awhile there, I didn't have to hover at all.
Then I deleted my local repository, downloaded and rebuilt. It's working much better now.
However, I would like to turn this feature off. If we're going to add features that popup, we should also give the user a chance to turn them off.
--- End quote ---
--- Quote from: jens on January 21, 2011, 10:29:34 pm ---I'm currently working on a patch, that alows turning off tooltips completely and to change the dwelltime.
--- End quote ---
Applied to trunk svn r6936 !
Jenna:
--- Quote from: jens on December 16, 2010, 03:42:10 pm ---
--- Quote from: oBFusCATed on December 14, 2010, 03:38:42 pm ---Jens (as our auiNotebook spe[spammer]t): I have another feature request:
The problem is:
1. open tabs, so that all tabs can't be visible at the same time
2. scroll to the last tab
3. close the last tab
4. the tabs on the left of the last tab don't move.
Is it possible to make tabs on the left move to the right
(the notebook will behave like the one in firefox for example)?
--- End quote ---
I will attach a patch later this day (or tomorrow)
--- End quote ---
Applied to trunk svn r6937 !
Navigation
[0] Message Index
[#] Next page
[*] Previous page
Go to full version