Developer forums (C::B DEVELOPMENT STRICTLY!) > Development

Request : C::B View::notebook enhancements

<< < (15/23) > >>

Pecan:
For awhile there, I didn't have to hover at all.

Then I deleted my local repository, downloaded and rebuilt. It's working much better now.

However, I would like to turn this feature off. If we're going to add features that popup, we should also give the user a chance to turn them off.
 

Jenna:
I'm currently working on a patch, that alows turning off tooltips completely and to change the dwelltime.

MortenMacFly:
I've experienced an issue with this patch on Windows Vista meanwhile. It's (however) VERY weired, I am tryinig to explain anyways:
1.) steps to reproduce (crashes always for me)
- startup a fresh C::B
- open a workspace with a saved last opened editor window, so thatt his editor window is re-opened when opening the workspace
- close the editor via the "X"
- open another file from the project tree
-> You'll see the new editor quickly and then -> CRASH.

In the debugger you#ll see the image as attached. It's this line that fails:
m_pLastFocused->SetFocus();
...in void cbAuiNotebook::RestoreFocus().

However, I don't get why it fails. Comparing the addresses shows that the address of m_pLastFocused is indeed not the one of nullptr. However, it seems also not to be a valid address to a wxWindow -> or probably it hasn't been reset. Now I wonder how that can be. m_pLastFocused is initialised with nullptr or set in void cbAuiNotebook::StoreFocus(). So for me either its a valid pointer or not. The only thing I can imagine is that the window that had the focus (most likely the previous editor) is not released properly on destruction and thus the pointer is not being cleared.

Any ideas? Notice that this happens ONLY on windows Vista for me. All other Windows's I drive are working properly with a binary identical C::B and wxWidgets version.


EDIT: Notice that this does NOT happen if I disable to open the last used editors from settings -> environment -> On project load... I might have disabled this option on the other Windows's, but I can't have a look atm...

Jenna:

--- Quote from: MortenMacFly on January 21, 2011, 10:38:07 pm ---I've experienced an issue with this patch on Windows Vista meanwhile. It's (however) VERY weired, I am tryinig to explain anyways:
1.) steps to reproduce (crashes always for me)
- startup a fresh C::B
- open a workspace with a saved last opened editor window, so thatt his editor window is re-opened when opening the workspace
- close the editor via the "X"
- open another file from the project tree
-> You'll see the new editor quickly and then -> CRASH.

In the debugger you#ll see the image as attached. It's this line that fails:
m_pLastFocused->SetFocus();
...in void cbAuiNotebook::RestoreFocus().

However, I don't get why it fails. Comparing the addresses shows that the address of m_pLastFocused is indeed not the one of nullptr. However, it seems also not to be a valid address to a wxWindow -> or probably it hasn't been reset. Now I wonder how that can be. m_pLastFocused is initialised with nullptr or set in void cbAuiNotebook::StoreFocus(). So for me either its a valid pointer or not. The only thing I can imagine is that the window that had the focus (most likely the previous editor) is not released properly on destruction and thus the pointer is not being cleared.

Any ideas? Notice that this happens ONLY on windows Vista for me. All other Windows's I drive are working properly with a binary identical C::B and wxWidgets version.


EDIT: Notice that this does NOT happen if I disable to open the last used editors from settings -> environment -> On project load... I might have disabled this option on the other Windows's, but I can't have a look atm...

--- End quote ---

That's a show stopper for me.

I will try to investigate, nut not this  weekend (no time).
I have an idea what to do, so I try to reproduce and fix it next week.

I will not commit, before the cause is found.

MortenMacFly:

--- Quote from: jens on January 22, 2011, 07:51:07 am ---That's a show stopper for me.
[...]
I will not commit, before the cause is found.

--- End quote ---
Agreed.

Navigation

[0] Message Index

[#] Next page

[*] Previous page

Go to full version