User forums > Nightly builds
The 27 February 2010 build (6181) is out.
oBFusCATed:
Jens: have you tried my patch, do you experience the same problem (red background) with it?
foobar123:
--- Quote from: jens on April 09, 2010, 11:22:26 pm ---
--- Quote from: foobar123 on April 09, 2010, 07:49:06 pm ---I still haven't figured out how to set the colour of the notebook tabs properly - I can't find the place where the black text colour is hardcoded. This might even be in the wx libraries.
--- End quote ---
You can try this one, at least for C::B's own styles (MSVC anf FF2):
--- End quote ---
Thanks, I will try. I'm using the Simple Tabs style though, and I think the code for that is in the wx libraries. Anyway, that's a minor thing, the tab text is readable :)
--- Quote ---
--- Quote from: foobar123 on April 09, 2010, 07:49:06 pm ---I hope this patch will be applied before the next release!
--- End quote ---
I don't think this should be done.
First: we are in a feature freeze and only release-critical bugs should be fixed and even if it might be annoying for users of dark themes, it's not release-critical in my opinion, and any fixes should be tested long enough.
--- End quote ---
Of course it should be tested, but this is a small change, which wouldn't need a long time to test. And it's not something that changes any critical internals either, so I'd say now is as good a time to fix this than ever. I'm not a Code::Blocks developer though...
--- Quote ---Second: I just tried the patch and after an error and the text: "Process terminated with status 1 (0 minutes, 0 seconds)" with a red background, the background of all newly added text in the Build log stays red.
debian 64 bit, svn r6202, wxWidgets 2.8.10, gcc 4.4.3
--- End quote ---
You're right, I can reproduce this. I'm attaching the patch again, this time the background colors are set correctly (loggers.cpp lines 62 and 89).
[attachment deleted by admin]
Jenna:
--- Quote from: oBFusCATed on April 09, 2010, 11:51:13 pm ---Jens: have you tried my patch, do you experience the same problem (red background) with it?
--- End quote ---
No (I don't like dark themes, so no need to test it until now, and really not very much time at the moment), but I already fixed the red-background issue.
Here is a snippet of the changed patch to loggers.cpp :
--- Code: ---@@ -61,12 +78,14 @@
// might try alternatively
//italic_font.SetStyle(wxFONTSTYLE_SLANT);
+ wxColour default_text_colour = wxSystemSettings::GetColour(wxSYS_COLOUR_WINDOWTEXT);
+ wxColour default_bg_colour = wxSystemSettings::GetColour(wxSYS_COLOUR_WINDOW);
for(unsigned int i = 0; i < num_levels; ++i)
{
style[i].SetFont(default_font);
style[i].SetAlignment(wxTEXT_ALIGNMENT_DEFAULT);
- style[i].SetTextColour(*wxBLACK);
- style[i].SetBackgroundColour(*wxWHITE);
+ style[i].SetBackgroundColour(default_bg_colour);
+ style[i].SetTextColour(default_text_colour);
// is it necessary to do that?
//style[i].SetFlags(...);
--- End code ---
EDIT:
our posts crossed each other
oBFusCATed:
--- Quote from: jens on April 10, 2010, 12:03:04 am ---No (I don't like dark themes, so no need to test it until now, and really not very much time at the moment), but I already fixed the red-background issue.
--- End quote ---
I also don't like the extremely dark (black) themes, but gray themes are OK for me :)
--- Quote from: jens on April 10, 2010, 12:03:04 am ---
--- Code: ---+ wxColour default_text_colour = wxSystemSettings::GetColour(wxSYS_COLOUR_WINDOWTEXT);
+ wxColour default_bg_colour = wxSystemSettings::GetColour(wxSYS_COLOUR_WINDOW);
--- End code ---
--- End quote ---
Isn't it better to use control->GetForegroundColour()/GetBackgroundColour()?
Also your notebook patch is not OK, with my theme and ff2 style: http://smrt.is-a-geek.org/codeblocks/screens/notebook_patch_bug.png
--- Quote from: foobar123 on April 10, 2010, 12:01:13 am ---Of course it should be tested, but this is a small change, which wouldn't need a long time to test. And it's not something that changes any critical internals either, so I'd say now is as good a time to fix this than ever. I'm not a Code::Blocks developer though...
--- End quote ---
It is not so easy to test it, because there are lots of gtk2 themes + windows xp/vista/7...
foobar123:
--- Quote from: oBFusCATed on April 10, 2010, 12:17:20 am ---Isn't it better to use control->GetForegroundColour()/GetBackgroundColour()?
--- End quote ---
Yeah it might. I wrote this quickly and I'm not familiar with wxWidgets.
--- Quote ---
--- Quote from: foobar123 on April 10, 2010, 12:01:13 am ---Of course it should be tested, but this is a small change, which wouldn't need a long time to test. And it's not something that changes any critical internals either, so I'd say now is as good a time to fix this than ever. I'm not a Code::Blocks developer though...
--- End quote ---
It is not so easy to test it, because there are lots of gtk2 themes + windows xp/vista/7...
--- End quote ---
Ok, this might be true for the "brightening" of colors (the BlendTextColour function). But when choosing default theme colors for background and text, one can't really do anything wrong? In any case, choosing black for the foreground and leaving the background to the theme, as it was done e. g. in the search result logger, is about the worst combination one could do, no?
This article is about web pages, but I think it applies here too: "If You Pick One Color, Pick Them All" http://www.w3.org/QA/Tips/color
Maybe we could agree on using GetXgroundColor() or wxSystemSettings::GetColour() for default text in loggers for now, and find a way to create contrasting warning/error messages later? Meaning, simple Red and Blue contrast pretty much any colour, so we can leave them as they are for now. Would be a step in the right direction IMHO.
If you don't want to do this, at least force the background colors to white. Even if that hurts my eyes ;o)
Navigation
[0] Message Index
[#] Next page
[*] Previous page
Go to full version