User forums > Nightly builds
The 27 February 2010 build (6181) is out.
foobar123:
--- Quote from: oBFusCATed on April 08, 2010, 02:35:21 pm ---The matter is that the error lines are red, warning lines are blue and these two colors doesn't work well on black background...
Thought you're right that the normal text color should (and can easily) be fixed.
--- End quote ---
Yes, dark blue doesn't work well on dark backgrounds either, but at least it's readable. Doing this whole thing correctly would involve either making the error and warning message color configurable, or composing the colors from a mixture of the default text foreground color and the desired color. I imagine mixing 25% default text color + 75% desired color would work well.
--- Quote ---mods: can you move the post related to dark skins in another thread?
--- End quote ---
I thought this was the right thread for discussing bugs which should be fixed before the next release. Outputting text which can't be read is a bug.
oBFusCATed:
--- Quote from: foobar123 on April 08, 2010, 04:06:04 pm ---Yes, dark blue doesn't work well on dark backgrounds either, but at least it's readable. Doing this whole thing correctly would involve either making the error and warning message color configurable, or composing the colors from a mixture of the default text foreground color and the desired color. I imagine mixing 25% default text color + 75% desired color would work well.
--- End quote ---
Have you used the 25% + 75% scheme somewhere?
--- Quote from: foobar123 on April 08, 2010, 04:06:04 pm ---I thought this was the right thread for discussing bugs which should be fixed before the next release. Outputting text which can't be read is a bug.
--- End quote ---
I think no, there is Preparing for Release thread. Also this is not a regression, but normal bug.
foobar123:
--- Quote from: oBFusCATed on April 08, 2010, 07:06:17 pm ---Have you used the 25% + 75% scheme somewhere?
--- End quote ---
No, it's an "educated guess" kind of thing. It might not look pretty with all color schemes but it would make the text more readable than it is now.
foobar123:
Text colours again.
I've created a patch which applies to current svn head. This includes [ Patch #2855 ] Dark theme fixes and also fixes the default colors for loggers like the search results. If the colour scheme is a bright-on-dark one, it also brightens the warning and error messages in the build messages, which makes them more readable (see screenshot).
I still haven't figured out how to set the colour of the notebook tabs properly - I can't find the place where the black text colour is hardcoded. This might even be in the wx libraries.
I hope this patch will be applied before the next release!
[attachment deleted by admin]
Jenna:
--- Quote from: foobar123 on April 09, 2010, 07:49:06 pm ---I still haven't figured out how to set the colour of the notebook tabs properly - I can't find the place where the black text colour is hardcoded. This might even be in the wx libraries.
--- End quote ---
You can try this one, at least for C::B's own styles (MSVC anf FF2):
--- Code: ------ tmp/tmpq4jmq6-meld/notebookstyles.cpp
+++ home/jens/codeblocks-build/codeblocks.trunk/src/src/notebookstyles.cpp
@@ -155,6 +155,7 @@
dc.SetFont(m_normal_font);
dc.GetTextExtent(caption, &textx, &texty);
// draw tab text
+ dc.SetTextForeground(wxSystemSettings::GetColour(wxSYS_COLOUR_CAPTIONTEXT));
dc.DrawText(page.caption, text_offset,
drawn_tab_yoff + drawn_tab_height / 2 - texty / 2 - 1);
@@ -323,6 +324,7 @@
dc.SetFont(m_normal_font);
dc.GetTextExtent(caption, &textx, &texty);
// draw tab text
+ dc.SetTextForeground(wxSystemSettings::GetColour(wxSYS_COLOUR_CAPTIONTEXT));
dc.DrawText(page.caption, text_offset,
drawn_tab_yoff + drawn_tab_height / 2 - texty / 2 - 1);
--- End code ---
--- Quote from: foobar123 on April 09, 2010, 07:49:06 pm ---I hope this patch will be applied before the next release!
--- End quote ---
I don't think this should be done.
First: we are in a feature freeze and only release-critical bugs should be fixed and even if it might be annoying for users of dark themes, it's not release-critical in my opinion, and any fixes should be tested long enough.
Second: I just tried the patch and after an error and the text: "Process terminated with status 1 (0 minutes, 0 seconds)" with a red background, the background of all newly added text in the Build log stays red.
debian 64 bit, svn r6202, wxWidgets 2.8.10, gcc 4.4.3
Navigation
[0] Message Index
[#] Next page
[*] Previous page
Go to full version