New code completion remarks/issues

[ollydbg]

@blueshake:

look at the Get function prototype, it is a static function.

Code

class DLLIMPORT Manager
{
    static Manager* Get();
}

but, in the symbol tree debug dialog, you will see that the

type is Manager *
actual type is Manager

That's may be the cause of bug...

But it worked before.I updated the local copy,and it don't work.
look at these codes.The static are ignored.

Code

        else if (token==ParserConsts::kw_static ||
            token==ParserConsts::kw_virtual ||
            token==ParserConsts::kw_inline)
        {
            // do nothing (skip it)
        }

Hi, after one and a half hour examing. I find the bug, and the patch to fix it.

Code

Index: nativeparser.cpp
===================================================================
--- nativeparser.cpp	(revision 5834)
+++ nativeparser.cpp	(working copy)
@@ -1465,7 +1465,7 @@
                 tokenType = pttNamespace;
             else
                 tokenType = pttClass;
-            line.Remove(0, startAt + 2);
+            line.Remove(0, startAt + 1);
         }
         else
             line.Clear();

Here is the explanation:

For the code:

Code

Manager::Get()->

The nativeparser should divide the line to "Manager" and "Get".

The current trunk code just mistakenly divide to "Manager" and "et", so, this patch can solve the bug.

[blueshake]

Cool man.

I just check the codes,found that we used IsOperatorEnd(startAt, line),so this is why patch should be applied.

@ollydbg
watch these codes in nativeparser.cpp

Code

        startAt = BeginOfToken(startAt, line);

        // Check for [Class]. ('.' pressed)
        if (IsOperatorDot(startAt, line))
        {
            --startAt;
            repeat = true; // yes -> repeat.
        }
        // Check for [Class]-> ('>' pressed)
        // Check for [Class]:: (':' pressed)
        else if (IsOperatorEnd(startAt, line))
        {
            startAt -= 2;
            repeat = true; // yes -> repeat.
        }

[/s]

should the startAt -=2;be changed to startAt -=1;.I think the reason is same to the patch.

[blueshake]

I can confirm the issues I reported in reply 93,#99 can be fixed by ollydbg's #105 patch,even the tkTypedef can work too.

[ollydbg]

I can confirm the issues I reported in reply 93,#99 can be fixed by ollydbg's #105 patch,even the tkTypedef can work too.

I'm so grad to hear that!!!! :lol:

[mmkider]

Hi
I found a issue.

if stest is a struct;

stest->b. ;   //this is fail. Tip window can't pop up c
stest.b.c  ;  //this  is ok .

[blueshake]

Hi
I found a issue.

if stest is a struct;

stest->b. ;   //this is fail. Tip window can't pop up c
stest.b.c  ;  //this  is ok .

Full test codes,please.

[mmkider]

Code

typedef struct U_TKey{
	int u32Key;

}U_KEYPAD_TWOKEY;

typedef struct S_KeyPad{
	U_KEYPAD_TWOKEY	   unTKey;
	void *			   pParam;
	char 			   u8CallBack_Type;
	char  u8DebounceClk;
	char  u8IntNum;
	char  u8TriggerType;
}S_KEYPAD_CLASS;

It's ok

Code

S_KEYPAD_CLASS  sTest;
sTest.unTKey.u32Key=10;

It's fail.

Code

S_KEYPAD_CLASS  *psTest;
psTest->unTkey.     // can't popup u32Key 

[MortenMacFly]

This works fine here:

Code

  S_KEYPAD_CLASS *psTest;
  psTest->unTKey.

("u32Key" will be suggested).

...version, patform etc?

[mmkider]

This works fine here:

Code

  S_KEYPAD_CLASS *psTest;
  psTest->unTKey.

("u32Key" will be suggested).

...version, patform etc?

I use codeblocks svn 5839 in the WinXp sp2.
In my system, "u32Key" will not be suggested.

Code

S_KEYPAD_CLASS  *psTest;
psTest->unTkey.                      // can't popup u32Key 

[blueshake]

Work here,too.see the attachment.

Sorry to say that,but tktypedef don't work again.ollydbg is right,something is wrong with codes below,if I comment them,worked.!!!!!!!!

Code

        if (token->m_TokenKind == tkTypedef)
        {
            std::queue<ParserComponent> type_components;
            BreakUpComponents(parser, token->m_ActualType, type_components);

            while(!components.empty())
            {
                ParserComponent comp = components.front();
                components.pop();
                type_components.push(comp);
            }

    #if DEBUG_CC_AI
            if (s_DebugSmartSense)
            #if wxCHECK_VERSION(2, 9, 0)
                Manager::Get()->GetLogManager()->DebugLog(F(_T("Replacing %s to %s"), token->m_Name.wx_str(), token->m_ActualType.wx_str()));
            #else
                Manager::Get()->GetLogManager()->DebugLog(F(_T("Replacing %s to %s"), token->m_Name.c_str(), token->m_ActualType.c_str()));
            #endif
    #endif
            return FindAIMatches(parser, type_components, result, parentTokenIdx, noPartialMatch, caseSensitive, use_inheritance, kindMask, search_scope);
        }

    }

[attachment deleted by admin]

[mmkider]

Work here,too.see the attachment.

Sorry to say that,but tktypedef don't work again.ollydbg is right,something is wrong with codes below,if I comment them,worked.!!!!!!!!

Code

        if (token->m_TokenKind == tkTypedef)
        {
            std::queue<ParserComponent> type_components;
            BreakUpComponents(parser, token->m_ActualType, type_components);

            while(!components.empty())
            {
                ParserComponent comp = components.front();
                components.pop();
                type_components.push(comp);
            }

    #if DEBUG_CC_AI
            if (s_DebugSmartSense)
            #if wxCHECK_VERSION(2, 9, 0)
                Manager::Get()->GetLogManager()->DebugLog(F(_T("Replacing %s to %s"), token->m_Name.wx_str(), token->m_ActualType.wx_str()));
            #else
                Manager::Get()->GetLogManager()->DebugLog(F(_T("Replacing %s to %s"), token->m_Name.c_str(), token->m_ActualType.c_str()));
            #endif
    #endif
            return FindAIMatches(parser, type_components, result, parentTokenIdx, noPartialMatch, caseSensitive, use_inheritance, kindMask, search_scope);
        }

    }

I update src of codeblocks to SVN 5840.
It work well.

Thank all.

[MortenMacFly]

Sorry to say that,but tktypedef don't work again.ollydbg is right,something is wrong with codes below,if I comment them,worked.!!!!!!!!

What does not work exactly? My test cases all work very well...?! Are you using latest SVN code?

[mmkider]

Sorry to say that,but tktypedef don't work again.ollydbg is right,something is wrong with codes below,if I comment them,worked.!!!!!!!!

What does not work exactly? My test cases all work very well...?! Are you using latest SVN code?

I can't  update all easily.
Because I remain wxflatnotebook in the src of codeblocks.
So I use other folder to update new src of codeblocks  and trandsfer some codes  of  my interest to my old folder.
I thank I do some wrong  thing between the new folder and the old folder .

[ollydbg]

Sorry to say that,but tktypedef don't work again.ollydbg is right,something is wrong with codes below,if I comment them,worked.!!!!!!!!

What does not work exactly? My test cases all work very well...?! Are you using latest SVN code?

@Morten

blueshake's test code in this post:
http://forums.codeblocks.org/index.php/topic,11187.msg76788.html#msg76788

failed when entering "wwww", there is a flash of the suggestion list.

[Jenna]

failed when entering "wwww", there is a flash of the suggestion list.

CC works for me in this case on linux, but not on windows (immediately close of suggestion window -> flash), but CC believes wwwwwwwww is a class, that's most likely because of the tktypedef-stuff.