Developer forums (C::B DEVELOPMENT STRICTLY!) > Development

Splitting debugger in two - specific debugger and common GUI

<< < (67/136) > >>

oBFusCATed:

--- Quote from: cbexaminr on October 31, 2010, 04:48:33 am ---I do wonder why you changed the formal parameter DebuggerDriver* type to the GDB_driver* type in the step/next classes, when everything else in gdb_commands.h is receiving a parameter type of DebuggerDriver* ?

--- End quote ---
In order to remove some casts and to document the code by itselt, now someone when reading it will know that it only works with GDB_Driver, not with CDB_Driver.


--- Quote from: cbexaminr on October 31, 2010, 04:48:33 am ---I think I understand why you did everything else.

I do note that your patch includes the file cbplugin.h with the following change(s):
-#define PLUGIN_SDK_VERSION_MINOR 11
-#define PLUGIN_SDK_VERSION_RELEASE 13
+#define PLUGIN_SDK_VERSION_MINOR 12
+#define PLUGIN_SDK_VERSION_RELEASE 0

I don't know if that will cause you any trouble or not, but going from a 'release' of 13 to a release of '0' seems a bit strange. 

--- End quote ---
If I understand it correctly the version is something like 1.11.13 and I've modified it to be 1.12.0

to devs: Is RTTI enabled in C::B, can someone use it? On all platforms?

cbexaminr:
devs should still confirm regarding RTTI enablement...

but if SDK is part of core, I think the following (partial) search results for dynamic_cast<> suggests RTTI is enabled everywhere core builds:

sdk\cbstyledtextctrl.cpp:        if ( EditorBase* pParent = dynamic_cast<EditorBase*>(m_pParent) )
sdk\compilercommandgenerator.cpp:    ProjectBuildTarget* bt = dynamic_cast<ProjectBuildTarget*>(target);
sdk\projectoptionsdlg.cpp:        ProjectBuildTarget* bt = dynamic_cast<ProjectBuildTarget*>(base);
sdk\replacedlg.cpp:        controlToFocus = enabledMultiLine ? dynamic_cast<wxWindow*>(txtFind1) : dynamic_cast<wxWindow*>(cmbFind1);
sdk\replacedlg.cpp:        controlToFocus = enabledMultiLine ? dynamic_cast<wxWindow*>(txtFind2) : dynamic_cast<wxWindow*>(cmbFind2);
sdk\replacedlg.cpp:            controlToFocus = chkMultiLine2->GetValue() ? dynamic_cast<wxWindow*>(txtFind1) : dynamic_cast<wxWindow*>(cmbFind1);sdk\replacedlg.cpp:            controlToFocus = chkMultiLine1->GetValue() ? dynamic_cast<wxWindow*>(txtFind2) : dynamic_cast<wxWindow*>(cmbFind2);
sdk\scrollingdialog.cpp:        // The wxRTTI is wrong for wxNotebook in < 2.8.8 and 2.9, so use dynamic_cast instead
sdk\scrollingdialog.cpp:        wxBookCtrlBase* bookContentWindow = dynamic_cast<wxBookCtrlBase*>(dialog->GetContentWindow());
sdk\templatemanager.cpp:            case totProject: prj = dynamic_cast<cbProject*>(ret); break;

cbexaminr:
anomaly with tooltip/quickwatch hovering over marked text when using gdb

If several lines of text are marked, and the mouse pointer hovered over them, c::b will send the entire marked area to gdb as the argument to gdb's "output" command.  gdb appears to take the first non-blank characters as the argument to output, and then takes any subsequent lines as completely separate attempted commands.

In the situation I observed, the file contained the following lines of text:
VVVVVVVVVVVVVVVVVVVVVVVVVVVVVVVVVVVVVVVVVVVV
              //SYMBOL_NAME (sym) =
              SYMBOL_LINKAGE_NAME (sym) =
                TDS_SYMBOL_NAME (info, symbol.ts_register.tsr_name);
              SYMBOL_CLASS (sym) = LOC_TYPEDEF;
              SYMBOL_TYPE (sym) =
                tds_get_type (info, symbol.ts_register.tsr_type);
//
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

I had the area marked from point indicated by '^' in "SYMBOL_LINKAGE_NAME (sym) = ^" to the beginninig of the last commented line.

The debugger log shows:
>>>>>>cb_gdb:
> output
                TDS_SYMBOL_NAME (info, symbol.ts_register.tsr_name);
              SYMBOL_CLASS (sym) = LOC_TYPEDEF;
              SYMBOL_TYPE (sym) =
                tds_get_type (info, symbol.ts_register.tsr_type);
Argument required (expression to compute).
Undefined command: "TDS_SYMBOL_NAME".  Try "help".
Undefined command: "SYMBOL_CLASS".  Try "help".
Undefined command: "SYMBOL_TYPE".  Try "help".
Undefined command: "tds_get_type".  Try "help".
>>>>>>cb_gdb:>>>>>>cb_gdb:>>>>>>cb_gdb:>>>>>>cb_gdb:>>>>>>cb_gdb:

oBFusCATed:
Confirmed.
There are two possible solutions:
1. Use only the first row from the selected text
2. Display an error

Which do you prefer?

p.s. what happened with the review, I'm not rushing you :)

cbexaminr:

--- Quote from: oBFusCATed on November 09, 2010, 11:58:49 pm ---Confirmed.
There are two possible solutions:
1. Use only the first row from the selected text
2. Display an error

Which do you prefer?

--- End quote ---
Probably 1.


--- Quote from: oBFusCATed on November 09, 2010, 11:58:49 pm ---p.s. what happened with the review, I'm not rushing you :)

--- End quote ---
Started doing it in patch, botched patch up, so applied original patch but have yet to get back to comparing and applying changes in botched patch to original, and applying in code.

Maybe by this weekend.  (Life has interfered lately.)

Navigation

[0] Message Index

[#] Next page

[*] Previous page