Developer forums (C::B DEVELOPMENT STRICTLY!) > Development
Splitting debugger in two - specific debugger and common GUI
oBFusCATed:
This isn't problems... just ignore it...
oBFusCATed:
--- Quote from: MortenMacFly on October 28, 2010, 06:50:47 am ---I'm afraid I don't exactly know what you mean? Which project?
--- End quote ---
Uf, I've forgot to tell you about the test project...
It can be found here: http://smrt.is-a-geek.org/codeblocks/patches/dbg/test_dbg.zip
cbexaminr:
--- Quote from: oBFusCATed on October 28, 2010, 11:16:43 pm ---Uf, I've forgot to tell you about the test project...
--- End quote ---
(actually, you didn't - it just got embedded into one of the quoted items [several posts before this one])
oBFusCATed:
cbexaminer: I've looked at your patch, at last...
Here are some general suggestions:
1. Don't use abbreviations for the identifiers
2. Use camel-case for the identifiers: "m_myVar" instead of m_myvar
I've modified the patch a bit: http://smrt.is-a-geek.org/codeblocks/patches/dbg/disasm_changes_mine.patch
1. I've cleaned the code a bit, the behaviour should not be changed, please verify it.
2. Added a check if the disassembly dialog is visible in the step command base class.
The old patch was executing the disassembly command even if the dialog was closed.
More changes are required:
1. You should remove all the // TBD comments
2. You should improve the comments:
I can hardly follow them, because you've written some random thoughts or used too many words and I'm getting lost.
The comments should be short and clear.
3. A commit message will be needed - describe all the changes please...
Please do some cleaning and then I'll look at your patch again.
I've applied it in my local copy and I hope to do some development + testing tomorrow.
cbexaminr:
I've compared the diffs, and I did not see anything that would break the intended logical functionality I had.
I do wonder why you changed the formal parameter DebuggerDriver* type to the GDB_driver* type in the step/next classes, when everything else in gdb_commands.h is receiving a parameter type of DebuggerDriver* ?
I think I understand why you did everything else.
I do note that your patch includes the file cbplugin.h with the following change(s):
-#define PLUGIN_SDK_VERSION_MINOR 11
-#define PLUGIN_SDK_VERSION_RELEASE 13
+#define PLUGIN_SDK_VERSION_MINOR 12
+#define PLUGIN_SDK_VERSION_RELEASE 0
I don't know if that will cause you any trouble or not, but going from a 'release' of 13 to a release of '0' seems a bit strange.
I also don't know what, if any, trouble it may cause me applying your version of the patch to move forward from...? I expect I will not apply that part unless you advise otherwise.
Also, do you have any guesses as to why my svn diff drops/replaces the entire area of .xrc file even when I used the switches you specified? (I observe that yours did not.)
I will try to review comments and variable case for needed changes in the next few days.
Navigation
[0] Message Index
[#] Next page
[*] Previous page
Go to full version