Splitting debugger in two - specific debugger and common GUI

[MortenMacFly]

Where do I put a new header that should not be visible to the users in the sdk, only by the implementation?

Huh? What exactly do you mean? Notice that if the SDK needs this header file it had to be available.

[oBFusCATed]

I have:
a.h,b.h,a.cpp,b.cpp

in a.cpp I include b.h. b.h is included in no other header, so it should not be visible to the users of the sdk.

Where do I put b.h? At the moment I've put it in src\include.

Another thing:

I want to add the method:

void cbDebuggerPlugin::GetBreakpoints(some_container_type &container);

What should be the some_container_type?
WX_DEFINE_ARRAY(cbBreakPoint*, BreakpointsList); ?
std::vector<cbBreakPoint> ?
or class cbBreakPointList, that I have to define, manually?

The elements in the container should be owned by the container.

[MortenMacFly]

in a.cpp I include b.h. b.h is included in no other header, so it should not be visible to the users of the sdk.

Just leave it where it is. The SDK docu will take care of not including this file in the documentation. Alternatively (if it's a small helper class) you can also embed it on top of the actual class (so in a.h) and comment it accordingly. There are several SDK classes that do similar (with the embedded classes *not* to be used directly).

WX_DEFINE_ARRAY(cbBreakPoint*, BreakpointsList); ?
std::vector<cbBreakPoint> ?

I'd personally prefer the first, but if that would be the only "wx code" and you'd strive for portability sure std::vector is the thing to do.

[oBFusCATed]

I've some progress....  :lol:

0. I've added a DebuggerManager, to hold all debugger related stuff
1. I've extracted the Debug menu (should move the resource file thought). The code is moved in the DebuggerMenu class.
1.1. Some of the menu items work (start, stop, step, next, continue)
1.2. I've added submenu Debug->Active Debugger. I've added API calls to register/unregister debuggers. The menu items are radio items, and switching the active debugger works.
2. I've extracted the breakpoints dialog and edit breakpoints
3. I've move the code from DebuggerGDB::SyncEditor to DebuggerManager::SyncEditor

Here is the patch that shows the changes: http://smrt.is-a-geek.org/codeblocks/dbg_refactor/dbg_refactor0001.patch
Parallel to the changes I make to CB, I modify my gdb_mi debugger plugin, so I can test if the changes are working.
The plugin can be found here: svn://smrt.is-a-geek.org/cb_gdb_mi .
The things that work: stepping and setting breakpoints at the beginning (before you have started the debugger).

Next on my TODO:
1. extracting the dbg toolbar
2. rewriting the watches window from scratch,  using PropGrid control - if you know about a control that is more suitable for it, please tell me (I'm a beginner in wx programming)

Any feedback is welcome.  :lol:

[dmoore]

when you get this sufficiently ready, I'll try to make some time to offer myself as guinea pig and write a python debugger.

[MortenMacFly]

if you know about a control that is more suitable for it, please tell me (I'm a beginner in wx programming)

Great work so far. I'll try to apply the patch and see.
Concerning propgrid: If you want to use it please use the recent version of the wx (or wxCode) repo. Not the one bundled with wxSmith as this is very outdated. We have to update two plugins otherwise... ;-)

[mariocup]

Hi oBFrusCATed,

that sounds promising and I will take a look as soon as I have some free time.

[ollydbg]

Firstly, Thanks for your hard work!!!
The patches is only for Linux-like system, because only "CodeBlocks-unix.cbp" was modified. But I only has Windows system at hand. So, I need time to tune.

[oBFusCATed]

You could edit the patch manually and replace Codeblocks-unix.cbp with Codeblocks.cbp, it might work.
Although the changes aren't too massive, 4 new files and some moved files.

If someone fixes the windows project, he/she can send me the patch...

[ollydbg]

My first question is:

It seems there are files to be added to "sdk"(mainly header files), such as:

Code

@@ -508,6 +522,9 @@
 		<Unit filename="include/editarraystringdlg.h">
 			<Option target="sdk" />
 		</Unit>
+		<Unit filename="include/editbreakpointdlg.h">
+			<Option target="sdk" />
+		</Unit>
 		<Unit filename="include/editkeywordsdlg.h">
 			<Option target="sdk" />
 		</Unit>

and some files were added to "debugger"( mainly cpp files)

Code

@@ -1467,12 +1484,6 @@
 		<Unit filename="plugins/debuggergdb/backtracedlg.h">
 			<Option target="Debugger" />
 		</Unit>
-		<Unit filename="plugins/debuggergdb/breakpointsdlg.cpp">
-			<Option target="Debugger" />
-		</Unit>
-		<Unit filename="plugins/debuggergdb/breakpointsdlg.h">
-			<Option target="Debugger" />
-		</Unit>
 		<Unit filename="plugins/debuggergdb/cdb_commands.h">
 			<Option target="Debugger" />
 		</Unit>

So, my question is: Why not let them all stay in target "Debugger"?

[ollydbg]

By the way, I can't directly apply your patch with TortoiseSVN.
So, I need to do it manually.

Edit
The only thing I would like to implement in sdk is that if we are debugging, we should only show the tooltip from debugger plugin. Currently, both codecompletion and debugger tooltip will be shown. Though, the former one will always be canceled by the later one.

See the related topic here:

http://forums.codeblocks.org/index.php/topic,10708.msg73482.html#msg73482

[oBFusCATed]

ollydbg: Please read the first post in the thread, there I've explained why I'm doing this.

p.s. sorry for you problems with applying it, I've made the patch with "git diff" and I haven't tried to apply it.
p.s.s. the debugger plugin has more serious problems (slowness, bad watch window, etc) than the one you mention, so they have higher priority  for me.

[oBFusCATed]

I have a problem:
When I disable the DebuggerGDB plugin in "Plugin -> Manage plugins..." the "Debug" menu is removed.
Do someone knows where is the code that does the removal?
I couldn't find it and C::B crashes if I have two loaded debuggers and I try to disable both of them (tries to remove the menu twice).

[ollydbg]

Maybe, it is this function:

Code

bool PluginManager::DetachPlugin(cbPlugin* plugin)
{
    if (!plugin)
        return false;
    if (!plugin->IsAttached())
        return true;

    Manager::Get()->RemoveAllEventSinksFor(plugin);
    plugin->Release(Manager::IsAppShuttingDown());
    return true;
}

Then plugin->Release will do the whole job.

[Jenna]

I have a problem:
When I disable the DebuggerGDB plugin in "Plugin -> Manage plugins..." the "Debug" menu is removed.
Do someone knows where is the code that does the removal?
I couldn't find it and C::B crashes if I have two loaded debuggers and I try to disable both of them (tries to remove the menu twice).

I guess the error is another.
If a plugin is released the menubar gets recreated from scratch, no single menus get removed.
That means a menu can not be removed twice.
If you debug C::B from inside C::B you should be able to see the backtrace of the crash (if the call stack window is active) and put a breakpoint there to see the cause.