Author Topic: wxSmith ArtProvider/Toolbar issue (patch submitted)  (Read 2888 times)

Offline rj-away

  • Single posting newcomer
  • *
  • Posts: 3
wxSmith ArtProvider/Toolbar issue (patch submitted)
« on: September 17, 2007, 09:08:09 am »
I'm not sure if the usual protocol is to provide notice about submitted patches here or not but I recently submitted a patch to fix a non-critical but real bug in some of the handling of ArtProvider stuff for Toolbars. This patch "seemed to work fine for metm".

Offline byo

  • Plugin developer
  • Lives here!
  • ****
  • Posts: 837
Re: wxSmith ArtProvider/Toolbar issue (patch submitted)
« Reply #1 on: September 18, 2007, 09:01:23 pm »
Thanks for the patch. I haven't had much time to investigate it before but from what I've seen your solution (maybe not only inside wxToolbar but in wxBitmapIconProperty) is correct.

Regards
   BYO

Offline byo

  • Plugin developer
  • Lives here!
  • ****
  • Posts: 837
Re: wxSmith ArtProvider/Toolbar issue (patch submitted)
« Reply #2 on: September 18, 2007, 10:01:04 pm »
Ok, I've fixed that (little bit different from your). It worked for me but since I don't have debug wxWidges library I can't be sure. Could you test if the fix works ?

BYO

Offline rj-away

  • Single posting newcomer
  • *
  • Posts: 3
Re: wxSmith ArtProvider/Toolbar issue (patch submitted)
« Reply #3 on: September 24, 2007, 03:57:02 am »
Thank you byo, that seems to have solved the core issue with the wxArtProvider stuff.

One side issue, though, is that the #include for <wx/artprov.h> isn't being generated in the resulting cpp code.