Author Topic: [Scripted wizard] Not all pages are added into PageAreaSizer  (Read 3273 times)

Offline wxLearner

  • Multiple posting newcomer
  • *
  • Posts: 71
Hello,
as stated here, I think, all pages should get into the PageAreaSizer. Also, adding all pages should work for wx2.6 and wx2.8. At the moment, the minimal size of the scripted wizard isn't computed correctly (it's not wide enough) on my WinXP, if the wizard's "welcome page" isn't skipped. If I modify the code (wiz.cpp), and add all pages, the size seems to be good.
Is there a reason, not to add all pages into the wizard's PageAreaSizer?
« Last Edit: June 20, 2007, 10:44:27 am by wxLearner »

Offline Biplab

  • Developer
  • Lives here!
  • *****
  • Posts: 1874
    • Biplab's Blog
Re: [Scripted wizard] Not all pages are added into PageAreaSizer
« Reply #1 on: June 20, 2007, 10:59:09 am »
Is there a reason, not to add all pages into the wizard's PageAreaSizer?

If you add all the pages, then the wizard page gets truncated and only the image portion remains visible. It happens with wx-2.8.x.
Be a part of the solution, not a part of the problem.

Offline wxLearner

  • Multiple posting newcomer
  • *
  • Posts: 71
Re: [Scripted wizard] Not all pages are added into PageAreaSizer
« Reply #2 on: June 20, 2007, 11:38:11 am »
If you add all the pages, then the wizard page gets truncated and only the image portion remains visible. It happens with wx-2.8.x.
For me this issue doesn't appear, if really all pages are added (also the first one):
Code: [Select]
for (size_t i = 0; i < m_Pages.GetCount(); ++i) //start with 0, i.e. the first page
        m_pWizard->GetPageAreaSizer()->Add(m_Pages[i]);
I think, the issue, you have mentioned, appears only, if the first page isn't added, like it's done at the moment if wxCHECK_VERSION(2, 8, 0) is false:
Code: [Select]
for (size_t i = 1; i < m_Pages.GetCount(); ++i) //start with 1 and ignore the first page
        m_pWizard->GetPageAreaSizer()->Add(m_Pages[i]);

Offline Biplab

  • Developer
  • Lives here!
  • *****
  • Posts: 1874
    • Biplab's Blog
Re: [Scripted wizard] Not all pages are added into PageAreaSizer
« Reply #3 on: June 20, 2007, 11:48:27 am »
If you add all the pages, then the wizard page gets truncated and only the image portion remains visible. It happens with wx-2.8.x.
For me this issue doesn't appear, if really all pages are added (also the first one):

Let me check it. But it would be nice if it works that way.  :)

Update: It works well. :)
« Last Edit: June 20, 2007, 11:50:37 am by Biplab »
Be a part of the solution, not a part of the problem.

Offline Biplab

  • Developer
  • Lives here!
  • *****
  • Posts: 1874
    • Biplab's Blog
Re: [Scripted wizard] Not all pages are added into PageAreaSizer
« Reply #4 on: June 20, 2007, 02:29:09 pm »
Patch applied in rev 4119. Thanks for the fix. :)
Be a part of the solution, not a part of the problem.