Author Topic: Patch to translate 2 scripts  (Read 1034 times)

Offline gd_on

  • Lives here!
  • ****
  • Posts: 578
Patch to translate 2 scripts
« on: December 27, 2019, 09:49:14 am »
Here is a patch to allow the translation of two distributed scripts : plugin_find_broken_files.script and wx_help.script

gd_on
Windows 10 64 bits (20.04), svn C::B (last version or almost!), wxWidgets 3.1.4, Msys2 Compilers 10.2.0, 64 bits (seh, posix : gcc, g++ and gfortran in C:\msys64\mingw64) or 32 bits (sjlj, posix in C:\msys64\mingw32).

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 12828
    • Travis build status
Re: Patch to translate 2 scripts
« Reply #1 on: December 27, 2019, 03:31:15 pm »
Could you rework dynamically created strings to be done with some kind of formatting string?
"A " + something + " B" might not have the same form in another language, so it is better to be something like format("A %s B", something).
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline gd_on

  • Lives here!
  • ****
  • Posts: 578
Re: Patch to translate 2 scripts
« Reply #2 on: December 27, 2019, 04:40:36 pm »
I am not the author of these scripts. I simply replaced the some _T by _.
I understand your remark, but at least, for French translations it's not a problem (my work is already in launchpad).
I don't know if the script engine is clever enough to support %d or %s to format numbers and strings, and more, how this engine works.
Finally, I think that your remark concerns only 2 strings (line 88 and 116 in plugin_find_broken_files.script).
So, I'm certainly not the best guy to do such a work. May be the original author ? (who knows how to test that also deeply : at least, for French translation looks OK, but I don't know for other languages)

gd_on
« Last Edit: December 27, 2019, 05:25:10 pm by gd_on »
Windows 10 64 bits (20.04), svn C::B (last version or almost!), wxWidgets 3.1.4, Msys2 Compilers 10.2.0, 64 bits (seh, posix : gcc, g++ and gfortran in C:\msys64\mingw64) or 32 bits (sjlj, posix in C:\msys64\mingw32).